Conversation
vtnerd
requested changes
Sep 13, 2026
| // size_t is 32-bit on some targets (armv7): a Content-Length that | ||
| // can't fit is not a body we could hold, so reject it rather than | ||
| // truncate the reserve. | ||
| if constexpr (std::numeric_limits<std::uint64_t>::max() > std::numeric_limits<std::size_t>::max()) |
Owner
There was a problem hiding this comment.
This check shouldn't be needed, as the compiler should be able to optimize away the check below at compile-time.
| @@ -28,10 +28,11 @@ | |||
|
|
|||
| #include "subaddress_account.h" | |||
|
|
|||
Owner
There was a problem hiding this comment.
What is this fixing? Some WIN32 issue?
| # Keep windows.h from pulling in WinSock1: boost::asio needs WinSock2, and | ||
| # headers that include windows.h first would otherwise make its | ||
| # socket_types.hpp fail with "WinSock.h has already been included". | ||
| add_compile_definitions(WIN32_LEAN_AND_MEAN) |
Owner
There was a problem hiding this comment.
Doesn't this add to all projects/executables declared after this? I think we want target_add_compile_definitions(lwsf-api WIN32_LEAN_AND_MEAN) in the src folder.
Owner
|
The windows test also failed, and it's likely due to the changes introduced here. I'm not sure why that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes these build errors: