Fix respec-oas RENDER ERROR on Credential/Presentation schemas - #691
Draft
PatStLouis wants to merge 1 commit into
Draft
Fix respec-oas RENDER ERROR on Credential/Presentation schemas#691PatStLouis wants to merge 1 commit into
PatStLouis wants to merge 1 commit into
Conversation
Add type: object to the allOf role wrappers so respec-oas can render property tables for Credential, VerifiableCredential, Presentation, and VerifiablePresentation (clears all 12 TR table errors). Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
|
I think we ended up fixing the same issue in different ways @PatStLouis, I had just opened a PR on the respec-oas repo to fix these bugs here: w3c-ccg/respec-oas#5 Your solution is likely the better one as it doesn't involve a respec-oas update, that is unless this is a pattern we don't want to have to worry about in the future with other specification that also use respec1.0.1 and the above pattern. |
Collaborator
Author
|
Discussed: the group will wait until the respec fix is pushed upstream, if issues are resolved, this PR may be closed |
Collaborator
Author
|
Discussed: after #706 has been merge, revisit the spec and see if this fix is still needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allOfwithout a top-leveltype(falls through toRENDER ERRORand dumps the JSON schema).Credential,VerifiableCredential,Presentation,VerifiablePresentation.type: objectbeside eachallOfso the renderer takes the object path and mergesallOfproperties. SharedCredentialDocument/PresentationDocumentbases are unchanged.Affected endpoints (all 12 cells)
credentialverifiableCredentialverifiablePresentationpresentationverifiableCredentialpresentationsteps200verifiablePresentation200200201Test plan
npm run serveand confirm the 12 property tables no longer showRENDER ERROR@contextandtypefrom the document schemasnpm run lint(OpenAPI) still passesMade with Cursor