Skip to content

feat(controller): Reconcile TriageRun jobs - #305

Open
amwarrier wants to merge 4 commits into
codex/triage-run-apifrom
codex/triage-run-controller
Open

feat(controller): Reconcile TriageRun jobs#305
amwarrier wants to merge 4 commits into
codex/triage-run-apifrom
codex/triage-run-controller

Conversation

@amwarrier

@amwarrier amwarrier commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Summary

Add the TriageRun reconciler and structured triage action catalog to Application.

An Application declares a shared runner (command, base args, env, resources, timeout) plus action objects containing name, description, and optional action-specific args. Each selected TriageRun.spec.actions[].name is resolved before any work starts, so an invalid request cannot partially execute.

Each selected action gets its own owned one-shot Job. The Job inherits the Application workload's service account and runtime context, uses the smaller triage resource envelope, and invokes the shared runner as:

<command> <base args> <action name> <action args>

This keeps the controller application-agnostic while allowing the diagnostic container to choose the correct check set. The controller reads structured stdout, records per-action phase/results/summary in status.actionStatuses, and computes the aggregate run phase and summary.

Validation

  • Targeted controller, manifest parser, and structured-output tests pass.
  • A multi-action test verifies that selected actions produce independent owned Jobs and aggregate into one completed run.
  • The reconciler reports missing actions, missing Jobs, failed Jobs, and invalid output through status conditions.

Stack

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2e9911b2-f978-41a8-93e8-ecdbf9232c31

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/triage-run-controller

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@amwarrier
amwarrier marked this pull request as ready for review July 31, 2026 19:40
@amwarrier
amwarrier requested a review from a team as a code owner July 31, 2026 19:40
@amwarrier
amwarrier force-pushed the codex/triage-run-api branch from a79a269 to a093d55 Compare August 3, 2026 16:37
@amwarrier
amwarrier force-pushed the codex/triage-run-controller branch 2 times, most recently from 0bf21f7 to 1e100d3 Compare August 3, 2026 16:38
@amwarrier amwarrier changed the title feat(controller): reconcile TriageRun jobs feat(controller): Reconcile TriageRun jobs Aug 3, 2026
@amwarrier
amwarrier force-pushed the codex/triage-run-api branch from a093d55 to 373408f Compare August 3, 2026 16:40
@amwarrier
amwarrier force-pushed the codex/triage-run-controller branch 3 times, most recently from 9d87b4e to efc3799 Compare August 4, 2026 15:48
@amwarrier
amwarrier force-pushed the codex/triage-run-controller branch 2 times, most recently from 07c09bd to 865b231 Compare August 4, 2026 16:29
@amwarrier
amwarrier force-pushed the codex/triage-run-controller branch from 3bf759a to 418f4fd Compare August 6, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant