feat(controller): Reconcile TriageRun jobs - #305
Open
amwarrier wants to merge 4 commits into
Open
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
4 tasks
amwarrier
marked this pull request as ready for review
July 31, 2026 19:40
amwarrier
force-pushed
the
codex/triage-run-api
branch
from
August 3, 2026 16:37
a79a269 to
a093d55
Compare
amwarrier
force-pushed
the
codex/triage-run-controller
branch
2 times, most recently
from
August 3, 2026 16:38
0bf21f7 to
1e100d3
Compare
amwarrier
force-pushed
the
codex/triage-run-api
branch
from
August 3, 2026 16:40
a093d55 to
373408f
Compare
amwarrier
force-pushed
the
codex/triage-run-controller
branch
3 times, most recently
from
August 4, 2026 15:48
9d87b4e to
efc3799
Compare
amwarrier
force-pushed
the
codex/triage-run-controller
branch
2 times, most recently
from
August 4, 2026 16:29
07c09bd to
865b231
Compare
amwarrier
force-pushed
the
codex/triage-run-controller
branch
from
August 6, 2026 16:33
3bf759a to
418f4fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the
TriageRunreconciler and structured triage action catalog toApplication.An Application declares a shared runner (
command, baseargs, env, resources, timeout) plus action objects containingname,description, and optional action-specificargs. Each selectedTriageRun.spec.actions[].nameis resolved before any work starts, so an invalid request cannot partially execute.Each selected action gets its own owned one-shot Job. The Job inherits the Application workload's service account and runtime context, uses the smaller triage resource envelope, and invokes the shared runner as:
This keeps the controller application-agnostic while allowing the diagnostic container to choose the correct check set. The controller reads structured stdout, records per-action phase/results/summary in
status.actionStatuses, and computes the aggregate run phase and summary.Validation
Stack