Skip to content

fix: escape delimiters in substitution pattern, fix CI docs job - #6

Merged
wassimk merged 1 commit into
mainfrom
wm/fix-escape-and-ci
Feb 14, 2026
Merged

wassimk merged 1 commit into
mainfrom
wm/fix-escape-and-ci

Conversation

@wassimk

@wassimk wassimk commented Feb 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • Fix bug where visual selections containing / or \ corrupted the :s command delimiter structure by escaping with vim.fn.escape()
  • Fix CI docs job: scope push triggers to main, add refs/heads/main guard on auto-commit, bump git-auto-commit-action to v5
  • Add README note explaining the very magic (\v) regex design choice
  • Add test cases for / and \ escaping

Test plan

  • All 15 tests pass locally (make test)
  • make lint passes
  • CI build passes on GitHub Actions

The search word was interpolated directly into the `:s` command,
so visual selections containing `/` or `\` would corrupt the
delimiter structure. Now escaped via `vim.fn.escape()`.

Also align the docs CI job with gh-navigator.nvim: scope push
triggers to main, add ref guard on auto-commit step, and bump
git-auto-commit-action to v5.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@wassimk
wassimk merged commit b6f5a13 into main Feb 14, 2026
3 checks passed
@wassimk
wassimk deleted the wm/fix-escape-and-ci branch February 14, 2026 14:43
wassimk added a commit that referenced this pull request Feb 14, 2026
The search word was interpolated directly into the `:s` command,
so visual selections containing `/` or `\` would corrupt the
delimiter structure. Now escaped via `vim.fn.escape()`.

Also align the docs CI job with gh-navigator.nvim: scope push
triggers to main, add ref guard on auto-commit step, and bump
git-auto-commit-action to v5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant