Skip to content

feat: highlight matches immediately when substitution opens - #7

Merged
wassimk merged 1 commit into
mainfrom
wm/hlsearch-highlighting
Feb 14, 2026
Merged

wassimk merged 1 commit into
mainfrom
wm/hlsearch-highlighting

Conversation

@wassimk

@wassimk wassimk commented Feb 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • Set the search register (@/) before feeding the :s command so hlsearch highlights all matches as soon as the command line appears
  • Clean up README: add requirements section, fix heading levels (### instead of ####), add descriptions below each mode explaining the behavior, clarify the visual line mode workflow, fix trailing > on the \v note

Test plan

  • All 18 tests pass locally (make test)
  • make lint passes
  • CI passes
  • Manual: trigger substitution in normal mode — matches should highlight immediately
  • Manual: trigger substitution in visual mode — matches should highlight immediately

Set the search register before feeding the substitution command so
hlsearch highlights all matches as soon as the command line appears,
rather than waiting for the user to start typing.

Also clean up the README: add requirements section, fix heading
levels, clarify each mode's behavior, and explain the visual line
mode workflow more clearly.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@wassimk
wassimk merged commit 0cc2de1 into main Feb 14, 2026
3 checks passed
@wassimk
wassimk deleted the wm/hlsearch-highlighting branch February 14, 2026 15:04
wassimk added a commit that referenced this pull request Feb 14, 2026
Set the search register before feeding the substitution command so
hlsearch highlights all matches as soon as the command line appears,
rather than waiting for the user to start typing.

Also clean up the README: add requirements section, fix heading
levels, clarify each mode's behavior, and explain the visual line
mode workflow more clearly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant