fix: provide assoc_legendre fallback for libc++ (macOS build) - #80
Open
manishpaulish wants to merge 1 commit into
Open
fix: provide assoc_legendre fallback for libc++ (macOS build)#80manishpaulish wants to merge 1 commit into
manishpaulish wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spherical_harmonic.cppusesstd::assoc_legendre, one of the C++17 mathematical special functions. These are optional in the standard, and libc++ (the default standard library on macOS) does not implement them, so the build currently fails on macOS with:This replaces the two
std::assoc_legendrecall sites with a small standalone implementation using the standard upward recurrence. The convention matchesstd::assoc_legendreexactly (no Condon-Shortley phase). I verified the output is bit-identical to libstdc++'sstd::assoc_legendreacross a range of (l, m, x) values.The affected functions (
sph_harm/real_sph_harm) are reference routines not on the productionsphericartpath, so there is no performance impact. Verified thatlibsymmetrixnow builds cleanly on macOS (Apple Clang) with the Kokkos serial backend.