Repository navigation
fix(android): stop a stale dial showing the wrong tab, and make the LAN fallback reachable - #71
Merged
williamdes merged 2 commits intoNov 16, 2026
Conversation
…AN fallback reachable Returning to a session could show another tab's contents until it was disconnected: - a dial still in flight for the tab being left could outlive a switch and take the session's socket back; dials now carry a generation that a switch, a suspend and a close bump - the erase before a replay left the emulator's modes alone, so a tab left in a full-screen program showed through; the modes are reset first - a frame decoded during a switch could be queued after the queue was cleared - the transport was closed by ConnectBot's network-change reset although it redials itself, and a later tab tap then only changed the title - a switch did not record the tab for the app's own reconnect The local-address fallback did not work for a server on the phone's network: - the local set defaulted to empty, so the LAN preference never applied - the tab list asked only the primary address - an invalid fallback was dropped on save instead of blocking it - cleartext http was refused by the platform - a socket failing mid-walk started a redial that raced the walk Not compiled or run: no Android SDK was available where this was written. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G6dpqPucDGns6rELSQeSdr
android-apk runs only on pushes to android-app and signs with the release key, so a branch could not be verified before merging. This adds a pull-request check with no secrets: the unit tests and a debug build, through the same script. Claude-Session: https://claude.ai/code/session_01G6dpqPucDGns6rELSQeSdr
williamdes
marked this pull request as ready for review
November 16, 2026 08:27
williamdes
deleted the
claude/mobile-render-agent-fixes-3je33h-android
branch
November 16, 2026 08:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified by CI: the new
android-checkworkflow (unit tests and a debug build, no secrets, no publishing) passes on headb3852c2. The device behaviour is not checked: the tab-switch and LAN-fallback fixes need a run against a real daemon before the release workflow publishes them.Returning to a session showed another tab's contents
Disconnecting cured it because that builds a fresh bridge, emulator and transport.
ESC c, to avoid discarding the tab's background. How termlib handles each sequence was not verified on a device.The local-address fallback did not work
TabAtelierAddresses.localdefaulted to empty and neither construction site set it, so the LAN preference never applied to a real host. An established session can now also move back to a local address.192.168.1.10:8443, for example).http://is permitted (usesCleartextTraffic). That it was blocked before is inferred from the manifest and target SDK, not observed.CI
.github/workflows/android-check.yml(new): runs on pull requests toandroid-app. Unit tests and a debug build viascripts/build-apk.sh --debug. No secrets, no signing with the release key, no publishing.android-apk.ymlis unchanged and still the only release path.Not included
A shorter connect timeout for non-last addresses, a CA-signed certificate served on a LAN IP, wider LAN detection (IPv6,
100.64/10), and inheriting the scheme for a bare fallback entry.Tests
Added
theLocalAddressesAreDerivedFromTheAddressesThemselvesandtheModesAreResetBeforeTheErase, and updated the erase test for the new prefix. The generation guard has no test:openSocketAthas no seam for a fake socket.Generated by Claude Code