Conversation
mrts
requested changes
Sep 4, 2026
WE2-1240 Signed-off-by: Sven Mitt <svenzik@users.noreply.github.com>
mrts
requested changes
Sep 11, 2026
| @Override | ||
| public void addCorsMappings(CorsRegistry registry) { | ||
| registry.addMapping("/**") | ||
| .allowedOrigins(config.getCorsAllowedOrigin()) |
Member
There was a problem hiding this comment.
As discussed, let's reuse local-origin and get rid of corsAllowedOrigin:
Suggested change
| .allowedOrigins(config.getCorsAllowedOrigin()) | |
| .allowedOrigins(config.getLocalOrigin()()) |
Contributor
Author
There was a problem hiding this comment.
Unfortunately, it is not that easy.
Property file contains only local-origin property, but...
When allowing http in Web-eID WebExtension, web-eid app still signs nonce using https protocol (https://localhost:3000), even though developer is using http://localhost:3000 in browser address bar.
in backend, local-origin needs to be https://localhost:3000 during validation (or it fails), but cors needs to be http://localhost:3000, or it fails
We can either change web-eid app to sign http://localhost:3000 or separate local-origin and cors-allowed-origin for above mentioned web-eid app issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add spa support for CSRF by setting into cookie
Signed-off-by: Sven Mitt svenzik@users.noreply.github.com