Conversation
NFC-46 Signed-off-by: Sander Kondratjev <sander.kondratjev@nortal.com> Co-authored-by: Mart Aarma <mart.aarma@nortal.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (!matcher.matches()) { | ||
| return null; | ||
| } | ||
| final int major = Integer.parseInt(matcher.group(1)); |
Contributor
Author
There was a problem hiding this comment.
Safe to dismiss due to regex pattern validation?
| return null; | ||
| } | ||
| final int major = Integer.parseInt(matcher.group(1)); | ||
| final int minor = matcher.group(2) == null ? 0 : Integer.parseInt(matcher.group(2)); |
Contributor
Author
There was a problem hiding this comment.
Safe to dismiss due to regex pattern validation?
…ation Add a short section to the library and example READMEs that lists only what an application with a working regular Web eID integration has to change or add for the mobile authentication flow, with links to the existing sections and example classes that implement each step. Signed-off-by: Mart Aarma <mart.aarma@nortal.com> Co-authored-by: Sander Kondratjev <sander.kondratjev@nortal.com>
aarmam
force-pushed
the
web-eid-mobile
branch
from
September 14, 2026 12:43
0027925 to
0b7c505
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sander Kondratjev sander.kondratjev@nortal.com
Co-authored-by: Mart Aarma mart.aarma@nortal.com