Repository navigation
Conversation
madislm
changed the title
madislm
force-pushed
the
AUT-2981
branch
4 times, most recently
from
October 5, 2026 12:17
5a45d6d to
56d68ae
Compare
Signed-off-by: Madis Jaagup Laurson <madisjaagup.laurson@nortal.com>
mrts
requested changes
Oct 8, 2026
| public static void validateKeyUsageDigitalSignature(X509Certificate certificate) throws OCSPCertificateException { | ||
| Objects.requireNonNull(certificate, "certificate"); | ||
| final boolean[] keyUsage = certificate.getKeyUsage(); | ||
| if (keyUsage == null) { |
Member
There was a problem hiding this comment.
Should requiring the Key Usage extension be configurable?
RFC 6960 §4.2.2.2 requires the OCSP Signing EKU for delegated responders, but does not require a Key Usage extension. RFC 5280 §4.2.1.12 requires consistent usage when both extensions are present.
The existing SK OCSP responder certificate has the OCSP Signing EKU but no Key Usage extension. Making this requirement configurable would preserve compatibility with it while allowing integrators to enforce the stricter policy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AUT-2981
Signed-off-by: Madis Jaagup Laurson <madisjaagup.laurson@nortal.com>