Add HTML setters features - #4318
Merged
Merged
Conversation
github-actions
Bot
added
the
feature definition
tunetheweb
commented
Sep 4, 2026
jamesnw
previously requested changes
Sep 4, 2026
Co-authored-by: James Stuckey Weber <james@oddbird.net>
ddbeck
self-requested a review
September 11, 2026 15:12
ddbeck
requested changes
Sep 15, 2026
ddbeck
left a comment
ddbeck
left a comment
Collaborator
There was a problem hiding this comment.
Hi @tunetheweb, thanks for your patience while I came back to this!
I have some mostly nitpicky suggestions and questions in line comments (though with one serious question about the name of the main setters feature). That said, I'm happy with the direction of this and I don't expect you to labor on it much longer. 😄
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
github-actions
Bot
added
the
tools and infrastructure
ddbeck
reviewed
Sep 16, 2026
ddbeck
left a comment
ddbeck
left a comment
Collaborator
There was a problem hiding this comment.
OK, one last question for you regarding sanitizer, but consider this a provisional approval. Thank you again for your work on this, @tunetheweb!
ddbeck
approved these changes
Sep 16, 2026
ddbeck
dismissed
jamesnw’s stale review
September 16, 2026 14:20
Outdated. Thank you for the early input, James!
Collaborator
|
At least five people contributed to understanding this and #4117. Thank you, @tunetheweb, @jamesnw, @jakearchibald, and @noamr! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4117
Due for launch in Chrome 154
Spec updates still WIP but have added commented out lines for them in the meantime.