Validate pull requests in TaskCluster #12657
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,81 +2,155 @@ version: 1 | |
| policy: | ||
| pullRequests: collaborators | ||
| tasks: | ||
| $flattenDeep: | ||
| - $if: tasks_for == "github-push" | ||
| then: | ||
| $map: | ||
| $flatten: | ||
| $match: { | ||
| event.ref == "refs/heads/master": [{name: firefox, channel: nightly}, {name: chrome, channel: dev}], | ||
| event.ref == "refs/heads/epochs/daily": [{name: firefox, channel: beta}, {name: chrome, channel: beta}], | ||
| event.ref == "refs/heads/epochs/weekly": [{name: firefox, channel: stable}, {name: chrome, channel: stable}] | ||
| } | ||
| each(browser): | ||
| $map: | ||
| - [testharness, 1, 15] | ||
| - [testharness, 2, 15] | ||
| - [testharness, 3, 15] | ||
| - [testharness, 4, 15] | ||
| - [testharness, 5, 15] | ||
| - [testharness, 6, 15] | ||
| - [testharness, 7, 15] | ||
| - [testharness, 8, 15] | ||
| - [testharness, 9, 15] | ||
| - [testharness, 10, 15] | ||
| - [testharness, 11, 15] | ||
| - [testharness, 12, 15] | ||
| - [testharness, 13, 15] | ||
| - [testharness, 14, 15] | ||
| - [testharness, 15, 15] | ||
| - [reftest, 1, 10] | ||
| - [reftest, 2, 10] | ||
| - [reftest, 3, 10] | ||
| - [reftest, 4, 10] | ||
| - [reftest, 5, 10] | ||
| - [reftest, 6, 10] | ||
| - [reftest, 7, 10] | ||
| - [reftest, 8, 10] | ||
| - [reftest, 9, 10] | ||
| - [reftest, 10, 10] | ||
| - [wdspec, 1, 1] | ||
| each(chunk): | ||
| taskId: {$eval: 'as_slugid(browser.name + browser.channel + chunk[0] + str(chunk[1]))'} | ||
| taskGroupId: {$eval: 'as_slugid("task group")'} | ||
| created: {$fromNow: ''} | ||
| deadline: {$fromNow: '24 hours'} | ||
| provisionerId: aws-provisioner-v1 | ||
| workerType: | ||
| $if: event.repository.full_name == 'web-platform-tests/wpt' | ||
| then: | ||
| wpt-docker-worker | ||
| else: | ||
| github-worker | ||
| metadata: | ||
| name: wpt-${browser.name}-${browser.channel}-${chunk[0]}-${chunk[1]} | ||
| description: >- | ||
| A subset of WPT's "${chunk[0]}" tests (chunk number ${chunk[1]} | ||
| of ${chunk[2]}), run in the ${browser.channel} release of | ||
| ${browser.name}. | ||
| owner: ${event.pusher.email} | ||
| source: ${event.repository.url} | ||
| payload: | ||
| image: jugglinmike/web-platform-tests:0.21 | ||
| maxRunTime: 7200 | ||
| artifacts: | ||
| public/results: | ||
| path: /home/test/artifacts | ||
| type: directory | ||
| command: | ||
| - /bin/bash | ||
| - --login | ||
| - -c | ||
| - set -ex; | ||
| ~/start.sh | ||
| ${event.repository.url} | ||
| ${event.ref} | ||
| ${event.after} | ||
| ${browser.name} | ||
| ${browser.channel}; | ||
| cd ~/web-platform-tests; | ||
| ./tools/ci/taskcluster-run.py | ||
| ${browser.name} | ||
| -- | ||
| --channel=${browser.channel} | ||
| --log-wptreport=../artifacts/wpt_report.json | ||
| --no-fail-on-unexpected | ||
| --test-type=${chunk[0]} | ||
| --this-chunk=${chunk[1]} | ||
| --total-chunks=${chunk[2]}; | ||
| - $if: tasks_for == "github-pull-request" | ||
| then: | ||
| $map: [{name: firefox, channel: nightly}, {name: chrome, channel: dev}] | ||
| each(browser): | ||
| $map: | ||
| - name: wpt-${browser.name}-${browser.channel}-stability | ||
| description: >- | ||
| Verify that all tests affected by a pull request are stable | ||
| when executed in ${browser.name}. | ||
| extra_args: '--verify' | ||
| - name: wpt-${browser.name}-${browser.channel}-results | ||
| description: >- | ||
| Collect results for all tests affected by a pull request in | ||
| ${browser.name}. | ||
| extra_args: '--no-fail-on-unexpected --log-wptreport=../artifacts/wpt_report.json' | ||
| each(operation): | ||
| taskId: {$eval: 'as_slugid(operation.name)'} | ||
| taskGroupId: {$eval: 'as_slugid("task group")'} | ||
| created: {$fromNow: ''} | ||
| deadline: {$fromNow: '24 hours'} | ||
| provisionerId: aws-provisioner-v1 | ||
| workerType: | ||
| $if: event.repository.full_name == 'web-platform-tests/wpt' | ||
| then: | ||
| wpt-docker-worker | ||
| else: | ||
| github-worker | ||
| metadata: | ||
| name: ${operation.name} | ||
| description: ${operation.description} | ||
| owner: ${event.pull_request.user.login}@users.noreply.github.com | ||
| source: ${event.repository.url} | ||
| payload: | ||
| image: jugglinmike/web-platform-tests:0.21 | ||
|
Member
There was a problem hiding this comment. A somewhat unrelated question: how can we create a public/shareable DockerHub account?
Contributor
Author
There was a problem hiding this comment. I don't know, but I think we all want that |
||
| maxRunTime: 7200 | ||
| artifacts: | ||
| public/results: | ||
| path: /home/test/artifacts | ||
| type: directory | ||
| # Fetch the GitHub-provided merge commit (rather than the pull | ||
| # request branch) so that the tasks simulate the behavior of the | ||
| # submitted patch after it is merged. Using the merge commit also | ||
| # simplifies detection of modified files because the first parent | ||
| # of the merge commit can consistently be used to summarize the | ||
| # changes. | ||
| command: | ||
| - /bin/bash | ||
| - --login | ||
| - -c | ||
| - set -ex; | ||
| ~/start.sh | ||
| ${event.repository.clone_url} | ||
| refs/pull/${event.number}/merge | ||
| FETCH_HEAD | ||
| ${browser.name} | ||
| ${browser.channel}; | ||
| cd ~/web-platform-tests; | ||
| result=0; | ||
| ./tools/ci/taskcluster-run.py | ||
| --commit-range HEAD^ | ||
| ${browser.name} | ||
| -- | ||
| --channel=${browser.channel} | ||
| ${operation.extra_args} || result=$?; | ||
| echo $result > ../artifacts/run-return-code.txt; | ||
| echo "Command exited with code $result (failures are allowed while this task is being vetted)." | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| #!/usr/bin/env python | ||
|
Contributor
There was a problem hiding this comment. So, I think I'm OK with landing this as-is, but I wonder what the effect would be of moving the logic in this file into |
||
|
|
||
| import argparse | ||
| import gzip | ||
| import logging | ||
| import os | ||
| import shutil | ||
| import subprocess | ||
|
|
||
| browser_specific_args = { | ||
| "firefox": ["--install-browser"] | ||
| } | ||
|
|
||
| def tests_affected(commit_range): | ||
| output = subprocess.check_output([ | ||
|
Contributor
There was a problem hiding this comment. You could, of course, just import and use the function directly rather than going via a process.
Member
There was a problem hiding this comment. @jgraham wouldn't that require hacking sys.path? If so, I'm in favour of forking.
Contributor
There was a problem hiding this comment. Yes. I think it makes more long term sense to move all of this into |
||
| "python", "./wpt", "tests-affected", "--null", commit_range | ||
| ], stderr=open(os.devnull, "w")) | ||
|
|
||
| tests = output.split("\0") | ||
|
|
||
| # Account for trailing null byte | ||
| if tests and not tests[-1]: | ||
| tests.pop() | ||
|
|
||
| return tests | ||
|
|
||
|
|
||
| def find_wptreport(args): | ||
| parser = argparse.ArgumentParser() | ||
| parser.add_argument('--log-wptreport', action='store') | ||
| return parser.parse_known_args(args)[0].log_wptreport | ||
|
|
||
|
|
||
| def gzip_file(filename): | ||
| with open(filename, 'rb') as f_in: | ||
| with gzip.open('%s.gz' % filename, 'wb') as f_out: | ||
| shutil.copyfileobj(f_in, f_out) | ||
|
|
||
|
|
||
| def main(product, commit_range, wpt_args): | ||
| """Invoke the `wpt run` command according to the needs of the TaskCluster | ||
| continuous integration service.""" | ||
|
|
||
| logger = logging.getLogger("tc-run") | ||
| logger.setLevel(logging.INFO) | ||
| handler = logging.StreamHandler() | ||
| handler.setFormatter( | ||
| logging.Formatter("%(asctime)s - %(name)s - %(levelname)s - %(message)s") | ||
| ) | ||
| logger.addHandler(handler) | ||
|
|
||
| child = subprocess.Popen(['python', './wpt', 'manifest-download']) | ||
|
jgraham marked this conversation as resolved.
|
||
| child.wait() | ||
|
|
||
| if commit_range: | ||
| logger.info( | ||
| "Identifying tests affected in range '%s'..." % commit_range | ||
| ) | ||
| tests = tests_affected(commit_range) | ||
| logger.info("Identified %s affected tests" % len(tests)) | ||
|
|
||
| if not tests: | ||
| logger.info("Quitting because no tests were affected.") | ||
| return | ||
| else: | ||
| tests = [] | ||
| logger.info("Running all tests") | ||
|
|
||
| wpt_args += [ | ||
| "--log-tbpl=../artifacts/log_tbpl.log", | ||
| "--log-tbpl-level=info", | ||
| "--log-mach=-", | ||
| "-y", | ||
| "--no-pause", | ||
| "--no-restart-on-unexpected", | ||
| "--install-fonts" | ||
| ] | ||
| wpt_args += browser_specific_args.get(product, []) | ||
|
|
||
| command = ["python", "./wpt", "run"] + wpt_args + [product] + tests | ||
|
|
||
| logger.info("Executing command: %s" % " ".join(command)) | ||
|
|
||
| subprocess.check_call(command) | ||
|
|
||
| wptreport = find_wptreport(wpt_args) | ||
| if wptreport: | ||
| gzip_file(wptreport) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| parser = argparse.ArgumentParser(description=main.__doc__) | ||
| parser.add_argument("--commit-range", action="store", | ||
| help="""Git commit range. If specified, this will be | ||
| supplied to the `wpt tests-affected` command to | ||
| determine the list of test to execute""") | ||
| parser.add_argument("product", action="store", | ||
| help="Browser to run tests in") | ||
| parser.add_argument("wpt_args", nargs="*", | ||
| help="Arguments to forward to `wpt run` command") | ||
| main(**vars(parser.parse_args())) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.