[WebMCP] Accept optional any inputObject in executeTool() - #62069
Merged
Conversation
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-8250826
branch
2 times, most recently
from
September 10, 2026 19:37
654645c to
ab3ad88
Compare
chromium-wpt-export-bot
marked this pull request as ready for review
September 10, 2026 20:47
This CL updates ModelContext.executeTool() to accept an optional `any inputObject` parameter instead of `DOMString inputArguments`, aligning with the latest WebMCP specification changes. The input object is validated and serialized to a JSON string in Blink before being passed over Mojo IPC to the target tool execution context. Any serialization errors (e.g. circular structures, non-serializable types, or toJSON returning undefined) reject the returned promise with a TypeError. Spec PRs: webmachinelearning/webmcp#246 webmachinelearning/webmcp#251 Bug: 489045948 Change-Id: I95cc00e20a84134cf5f289e689441587200555f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8250826 Reviewed-by: Dominic Farolino <dom@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#1695589}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-8250826
branch
from
September 10, 2026 20:47
ab3ad88 to
39664dd
Compare
wpt-pr-bot
approved these changes
Sep 10, 2026
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
Closed
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL updates ModelContext.executeTool() to accept an optional
any inputObjectparameter instead ofDOMString inputArguments,aligning with the latest WebMCP specification changes.
The input object is validated and serialized to a JSON string in Blink
before being passed over Mojo IPC to the target tool execution context.
Any serialization errors (e.g. circular structures, non-serializable
types, or toJSON returning undefined) reject the returned promise with a
TypeError.
Spec PRs:
webmachinelearning/webmcp#246
webmachinelearning/webmcp#251
Bug: 489045948
Change-Id: I95cc00e20a84134cf5f289e689441587200555f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8250826
Reviewed-by: Dominic Farolino <dom@chromium.org>
Commit-Queue: Fr <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/main@{#1695589}