ci: fix parallel build (-T) failure in pentaho-cdf-rca [DEVO-14414] - #1226
Open
cardosov wants to merge 1 commit into
Open
ci: fix parallel build (-T) failure in pentaho-cdf-rca [DEVO-14414]#1226cardosov wants to merge 1 commit into
cardosov wants to merge 1 commit into
Conversation
The unpack-plugins execution resolves pentaho:pentaho-cdf:zip via maven-dependency-plugin <artifactItems>, which are resolved directly from the repositories at execution time and do not participate in the reactor dependency graph. Serial builds only worked by accident of the <modules> declaration order; under -T the two modules are considered independent and run concurrently, so pentaho-cdf's zip is not yet attached when cdf-rca reaches process-sources. - Declare pentaho-cdf explicitly (provided/zip) so the reactor orders it before this module. - Move the unpack from process-sources to generate-resources, matching the pattern used by cdf-js and cdf-webpackage.
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
OSS Licenses | 0 0 0 0 |
View in Orca |
| Passed |
Malicious Packages | 0 0 0 0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
✅ Build finished in 5m 20sBuild command: mvn clean verify -B -e -Daudit -Djs.no.sandbox👌 All tests passed! Tests run: 71, Failures: 0, Skipped: 0 Test Results ℹ️ This is an automatic message |
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (27.20% Estimated after merge)
There was a problem hiding this comment.
🟢 Approval recommended
The changes are localized to build configuration and directly address the stated parallel build race by enforcing reactor ordering and consistent lifecycle binding.
Pull request overview
This PR fixes a Maven reactor ordering issue that caused pentaho-cdf-rca to race against the pentaho-cdf assembly during parallel builds (-T), by making the dependency explicit and aligning the unpack lifecycle phase with the established pattern in other assembly modules.
Changes:
- Adds an explicit
pentaho:pentaho-cdf(typezip, scopeprovided) dependency to create a reactor build-order edge. - Moves the
maven-dependency-pluginunpack-pluginsexecution fromprocess-sourcestogenerate-resources.
File summaries
| File | Description |
|---|---|
| assemblies/cdf-rca/pom.xml | Adds an explicit reactor dependency on pentaho-cdf and rebinds the unpack execution to generate-resources to avoid parallel build races. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cardosov
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unpack-plugins execution resolves pentaho:pentaho-cdf:zip via maven-dependency-plugin , which are resolved directly from the repositories at execution time and do not participate in the reactor dependency graph. Serial builds only worked by accident of the declaration order; under -T the two modules are considered independent and run concurrently, so pentaho-cdf's zip is not yet attached when cdf-rca reaches process-sources.