feat: Plasma for Core 400S, nightlight fixes, new device types + unknown device logging#530
Closed
Domocn wants to merge 5 commits into
Closed
feat: Plasma for Core 400S, nightlight fixes, new device types + unknown device logging#530Domocn wants to merge 5 commits into
Domocn wants to merge 5 commits into
Conversation
…iers - Add PLASMA to PurifierFeatures enum (const.py) - Add toggle_plasma/turn_on_plasma/turn_off_plasma methods to VeSyncAirBypass - Add plasma field handling in _update_details - Add PurifierFeatures.PLASMA to Core400S device map - Add HumidifierFeatures.NIGHTLIGHT to Classic200S device map - Add HumidifierFeatures.NIGHTLIGHT_RGB to Classic300S device map Fixes webdjoe#521, #160387, webdjoe#502
- Add PLASMA to PurifierFeatures enum (const.py) - Add toggle_plasma/turn_on_plasma/turn_off_plasma methods to VeSyncAirBypass - Add plasma field handling in _update_details - Add PurifierFeatures.PLASMA to Core400S device map - Add HumidifierFeatures.NIGHTLIGHT_RGB to Classic300S device map - Add HumidifierFeatures.NIGHTLIGHT to Classic200S device map - Add HumidifierFeatures.NIGHTLIGHT to OasisMist 450S (EU and US) device maps - Add toggle_nightlight/set_nightlight_brightness overrides to VeSyncSproutHumid to wire up the existing _set_nightlight_state helper to the public API Fixes webdjoe#521, webdjoe#528, webdjoe#500, #160387, webdjoe#502
- Add LPF-F361S-WUS, LPF-F362S-WUSR, LPF-F461S-WUS to VeSyncTowerFan - Add LPF-R382S-AEU, LPF-R382S-AUS to VeSyncPedestalFan - Add LUH-A603S-WUK (LV600S UK variant) to VeSyncLV600S - Add CS358-AF to VeSyncAirFryer158 Fixes webdjoe#525, webdjoe#523, webdjoe#526
Changes logger.debug to logger.info for unrecognized device types, making them visible in default Home Assistant logs without needing to enable debug logging. This helps users report new device types for inclusion in the device map.
for more information, see https://pre-commit.ci
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eacadce57a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Owner
|
Thank you for the PR and taking the time to work on this, but each issue needs to be broken into a separate pr because there are some issues that are not as clear cut as a simple fix: Here are some issues:
Please create separate PR's for these issues so that they can be appropriately tested and debugged individually before they are deployed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 8 issues and adds automatic device type reporting for future issues.
Feature additions
PurifierFeatures.PLASMA+toggle_plasma()method)HumidifierFeatures.NIGHTLIGHT_RGB)New device types (inferred from VeSync APK v5.9.10 model numbers)
LPF-R382S-AEU,LPF-R382S-AUS)LUH-A603S-WUK)CS358-AF)Logging improvement
Device type XXX not found in device map - please report thisChanges
const.pydevice_map.pyvesyncpurifier.pyvesynchumidifier.pydevice_container.pyDevice types were inferred from reverse-engineering the VeSync APK v5.9.10 (
com.etekcity.vesyncplatform).