forked from ppy/osu-framework
-
Notifications
You must be signed in to change notification settings - Fork 0
Veldrid submodule update, EGL front buffer auto-refresh, Android thread priority #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
winnerspiros
merged 12 commits into
master
from
copilot/optimize-veldrid-implementation
Apr 19, 2026
Merged
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
16e64ce
feat: Update Veldrid submodule, add EGL front buffer auto-refresh, se…
Copilot 7e6c87b
fix: Use imported Logger class consistently in AndroidGameHost
Copilot 216fad6
fix: Android build error (global:: namespace), update InspectCode, fi…
Copilot 663551e
style: Use named EGL constants instead of magic numbers in SDL3Graphi…
Copilot 44e9f63
plan: Add D3D12 renderer support and generalize low-latency provider
Copilot 179c027
feat: Integrate upstream PRs — D3D12 renderer, low-latency provider, …
Copilot 09c4359
fix: Add missing Description attributes, update README with all new f…
Copilot 141588b
fix: resolve 6 CI code quality errors (IDE0059, IDE0018, IDE1006, IDE…
Copilot 0cd8f82
Suppress iOS trim analysis warnings with UnconditionalSuppressMessage…
Copilot 424ed8a
fix: suppress iOS trim analysis warnings and Android JAVAC Kotlin ann…
Copilot 7c80434
fix: resolve all remaining CI warnings
Copilot b3251fd
fix: suppress remaining iOS trim analysis warnings in test files
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
osu.Framework/Graphics/Rendering/LowLatency/IDirect3D11LowLatencyProvider.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence. | ||
| // See the LICENCE file in the repository root for full licence text. | ||
|
|
||
| using System; | ||
|
Check failure on line 4 in osu.Framework/Graphics/Rendering/LowLatency/IDirect3D11LowLatencyProvider.cs
|
||
|
|
||
| namespace osu.Framework.Graphics.Rendering.LowLatency | ||
| { | ||
| /// <summary> | ||
| /// Low-latency provider specifically for Direct3D 11 backends (e.g. NVIDIA Reflex via D3D11). | ||
| /// </summary> | ||
| public interface IDirect3D11LowLatencyProvider : ILowLatencyProvider | ||
| { | ||
| } | ||
| } | ||
24 changes: 24 additions & 0 deletions
24
osu.Framework/Graphics/Rendering/LowLatency/ILowLatencyProvider.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence. | ||
| // See the LICENCE file in the repository root for full licence text. | ||
|
|
||
| using System; | ||
|
|
||
| namespace osu.Framework.Graphics.Rendering.LowLatency | ||
| { | ||
| /// <summary> | ||
| /// Generic low-latency provider interface supporting any graphics backend. | ||
| /// Implementations may use NVIDIA Reflex, LatencyFlex, or other latency reduction APIs. | ||
| /// </summary> | ||
| public interface ILowLatencyProvider | ||
| { | ||
| bool IsAvailable { get; } | ||
|
|
||
| void Initialize(IntPtr nativeDeviceHandle); | ||
|
|
||
| void SetMode(LatencyMode mode); | ||
|
|
||
| void SetMarker(LatencyMarker marker, ulong frameId); | ||
|
|
||
| void FrameSleep(); | ||
| } | ||
| } |
17 changes: 17 additions & 0 deletions
17
osu.Framework/Graphics/Rendering/LowLatency/LatencyMarker.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence. | ||
| // See the LICENCE file in the repository root for full licence text. | ||
|
|
||
| namespace osu.Framework.Graphics.Rendering.LowLatency | ||
| { | ||
| public enum LatencyMarker | ||
| { | ||
| SimulationStart, | ||
| SimulationEnd, | ||
| RenderSubmitStart, | ||
| RenderSubmitEnd, | ||
| PresentStart, | ||
| PresentEnd, | ||
| InputSample, | ||
| TriggerFlash | ||
| } | ||
| } |
12 changes: 12 additions & 0 deletions
12
osu.Framework/Graphics/Rendering/LowLatency/LatencyMode.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence. | ||
| // See the LICENCE file in the repository root for full licence text. | ||
|
|
||
| namespace osu.Framework.Graphics.Rendering.LowLatency | ||
| { | ||
| public enum LatencyMode | ||
| { | ||
| Off = 0, | ||
| On = 1, | ||
| Boost = 2 | ||
| } | ||
| } |
22 changes: 22 additions & 0 deletions
22
osu.Framework/Graphics/Rendering/LowLatency/NoOpDirect3D11LowLatencyProvider.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence. | ||
| // See the LICENCE file in the repository root for full licence text. | ||
|
|
||
| using System; | ||
|
|
||
| namespace osu.Framework.Graphics.Rendering.LowLatency | ||
| { | ||
| internal sealed class NoOpDirect3D11LowLatencyProvider : IDirect3D11LowLatencyProvider | ||
| { | ||
| public static readonly NoOpDirect3D11LowLatencyProvider INSTANCE = new NoOpDirect3D11LowLatencyProvider(); | ||
|
|
||
| public bool IsAvailable => false; | ||
|
|
||
| public void Initialize(IntPtr deviceHandle) { } | ||
|
|
||
| public void SetMode(LatencyMode mode) { } | ||
|
|
||
| public void SetMarker(LatencyMarker marker, ulong frameId) { } | ||
|
|
||
| public void FrameSleep() { } | ||
| } | ||
| } |
22 changes: 22 additions & 0 deletions
22
osu.Framework/Graphics/Rendering/LowLatency/NoOpLowLatencyProvider.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence. | ||
| // See the LICENCE file in the repository root for full licence text. | ||
|
|
||
| using System; | ||
|
|
||
| namespace osu.Framework.Graphics.Rendering.LowLatency | ||
| { | ||
| internal sealed class NoOpLowLatencyProvider : ILowLatencyProvider | ||
| { | ||
| public static readonly NoOpLowLatencyProvider INSTANCE = new NoOpLowLatencyProvider(); | ||
|
|
||
| public bool IsAvailable => false; | ||
|
|
||
| public void Initialize(IntPtr deviceHandle) { } | ||
|
|
||
| public void SetMode(LatencyMode mode) { } | ||
|
|
||
| public void SetMarker(LatencyMarker marker, ulong frameId) { } | ||
|
|
||
| public void FrameSleep() { } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EnumAdapters()returns a COM object that should be released/disposed after use. As written,adapterwill remain undisposed, which can leak native resources. Wrap the returned adapter in ausing/Dispose()(or otherwise release it) after reading the description.