chore: adopt UIScene lifecycle - WPB-25097 by samwyndham · Pull Request #4826 · wireapp/wire-ios

samwyndham · 2026-06-08T15:38:13Z

WPB-25097 [iOS] Adopt UISceneDelegate

Issue

This PR migrates the app for the UIScene lifecycle. This is necessary because apple will stope supporting the legacy lifecycle with iOS 27 SDK and the app will crash on launch:

Considering we have big plans for our apps architecture, this PR attempts to do a kind of minimum to solve the immediate problem without resorting to big hacks. It only supports a single app instance so we don't gain anything from these changes accept compatibility with the future SDK. To achieve this the following changes were necessary:

Introduced SceneDelegate that takes over some responsibilities from AppDelegate
Launch options are now bundled in UIScene.ConnectionOptions - an app can be launched with an array of URLs. In our case only the 1st URL is supported.
Deleted the ApplicationLaunchType. This abstraction is hard to make work with the UIScene lifecycle and it was only being used in two places:
- CallQualityController where a simple alternative was found
- SoundEventListener from testing this code never hit the appDelegate.launchType == .push path (the behavior doesn't work) so I just removed the related code.

Snapshot updates

There were 4 screens whose snapshots needed to be update. I looked into this and I don't believe there was any changes in the app - rather they relate to how snapshots are rendered in the library - specifically the view.safeAreaInsets that are applied to the view controllers being tested by the library.

I decided just to update the snapshots as the safe area insets applied in the snapshots are not related to those applied in the actual app.

Testing

General testing of the app.

Checklist

Title contains a reference JIRA issue number like [WPB-XXX].
Description is filled and free of optional paragraphs.
Adds/updates automated tests.

…ers()` directly

Launch options are nil when app is configured for scenes

This is already being set in AppDelegate.application(_:didReceiveRemoteNotification:fetchCompletionHandler:) and apples docs state on the deprecation notice: > "Continue using UIApplicationDelegate's application(_:didReceiveRemoteNotification:fetchCompletionHandler:) to process silent remote notifications after scene connection."

…rely on UIApplication.applicationState

This `launchType == .push` code path is never reached.

This notification is no longer observed

samwyndham · 2026-06-08T15:44:07Z

+	<key>UIApplicationSceneManifest</key>
+	<dict>
+		<key>UIApplicationSupportsMultipleScenes</key>
+		<false/>


We don't support multiple scenes. Changing this would be a big task

samwyndham · 2026-06-08T15:44:53Z

    static let pushChannel = WireLogger(tag: "push-channel")
-    static let webSocket = WireLogger(tag: "websocket")
-    static let proteus = WireLogger(tag: "proteus")
+    static let sceneDelegate = WireLogger(tag: "SceneDelegate")


This is the only content change in this file. Other than that I sorted the options.

samwyndham · 2026-06-08T15:47:51Z

-        _ application: ZMApplication,
-        didFinishLaunching launchOptions: [UIApplication.LaunchOptionsKey: Any?]
-    ) {
-        startEphemeralTimers()


This was moved to the caller of this method as this method no longer makes sense.

samwyndham · 2026-06-08T15:51:29Z

                .appendingPathComponent(remoteIdentifier.uuidString, isDirectory: true)
        }

-        NotificationCenter.default.post(name: NSNotification.Name.ZMUserSessionDidBecomeAvailable, object: nil)


This is no longer observed.

samwyndham · 2026-06-08T15:52:50Z

-    // Singletons
-    var unauthenticatedSession: UnauthenticatedSession? {
-        SessionManager.shared?.unauthenticatedSession
+    var mainWindow: UIWindow? {


This is now optional as its existence is a little later in the lifecycle.

samwyndham · 2026-06-08T15:53:40Z

-    private let cookieStorage = CookieStorage(cookieEncryptionKey: UserDefaults.cookiesKey())
+    // MARK: - Private properties

-    private lazy var voIPPushManager: VoIPPushManager = .init(
-        application: UIApplication.shared,
-        pushTokenService: pushTokenService
-    )
-
-    private let pushTokenService = PushTokenService()


These have moved to AppDependencies so they are accessible here and from the SceneDelegate.

github-actions · 2026-06-08T16:20:29Z

Test Results

3 010 tests 2 983 ✅ 3m 54s ⏱️
436 suites 27 💤
3 files 0 ❌

Results for commit e12dbf3.

♻️ This comment has been updated with latest results.

Summary: workflow run #27207229732
Allure report (download zip): html-report-30614-chore_adopt-uiscene-lifecycle-WPB-25097

datadog-wireapp · 2026-06-08T16:22:22Z

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: e12dbf3 | Docs | Give us feedback!}

sonarqubecloud · 2026-06-09T12:55:09Z

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

netbe

left some questions before approving

netbe · 2026-06-09T19:03:41Z

+    public func start(connectionOptions: UIScene.ConnectionOptions) async {
        if
-            let url = launchOptions[UIApplication.LaunchOptionsKey.url] as? URL,
+            let url = connectionOptions.urlContexts.first?.url, // Currently we only support one URL


question: what's the url? same as launch url so deeplink?

Yes exactly. I was not able to find the reason that this is now a collection of URLs. The best I could work out with the help of a LLM (e.g. maybe nonsense) is that:

An app could quickly try and launch our app with multiple calls in succession. The OS might batch these into a single instantiation.

Future proofing for future Apple plans.

I couldn't find a better explanation.

netbe · 2026-06-09T19:41:54Z

question: why are snapshots recorded here?

Oh right, I forgot to mention this in the description. I've updated the PR description. Please see there.

netbe · 2026-06-10T09:20:19Z

+
+    // MARK: - UISceneDelegate
+
+    var window: UIWindow?


suggestion: private set

I can't unfortunately because this is the UISceneDelegate API:

optional var window: UIWindow? { get set }

netbe · 2026-06-10T09:23:50Z

+            sceneConnectionOptions: connectionOptions
+        )
+
+        (UIApplication.shared.delegate as? AppDelegate)?.queueInitializationOperations()


question: should this be called inside the scenedelegate? maybe the launchOperations need some review. I wonder if some should be done even if a scene is not connected (background)

Conceptually launch options should really be handled by the AppDelegate as they shouldn't really be specific to a scene. I've taken some time to understand the launch operations better. As far as I understand these should really be done before we setup the appRouteRouter but there is some complexity here as access to things like group user defaults can be blocked by file protection. Making worthwhile changes here is somewhat risky and I don't want to really add additional risk to this current PR. Therefore I've created a Jira ticket to look into to this further: https://wearezeta.atlassian.net/browse/WPB-26555 and don't plan to address your comment in this PR.

David-Henner · 2026-06-11T08:42:46Z

-    func applicationWillEnterForeground(_ application: UIApplication) {
-        WireLogger.appDelegate.info(
-            "applicationWillEnterForeground: (applicationState = \(application.applicationState)",
-            attributes: .safePublic
-        )
-    }
-
-    func applicationDidBecomeActive(_ application: UIApplication) {
-        WireLogger.appDelegate.info(
-            "applicationDidBecomeActive (applicationState = \(application.applicationState))",
-            attributes: .safePublic
-        )
-
-        switch launchType {
-        case .url,
-             .push:
-            break
-        default:
-            launchType = .direct
-        }
-    }


question: what replaces the app lifecycle events since these are removed ?

These app lifecycle are no longer called on the AppDelegate. However, the equivalent notifications still exist and can be observed.

samwyndham added 29 commits June 2, 2026 17:55

Move basic setup to scene delegate

6e35421

Move appRootRouter and dependencies to SceneDelegate

4e0c16c

Migrate applicationDidBecomeActive

93d5f26

Migrate applicationWillResignActive

2205f13

Migrate applicationDidEnterBackground

6515346

Migrate applicationWillEnterForeground

64f27be

Migrate application(_:open:options:)

761e296

Migration continuing user activity

8c3334e

Fix forgetting to start observations

88aad1c

Simply some logic around creating the app router

f0b4c51

Introduce WireLogger.sceneDelegate

39bcfc0

Delete unused error case

8e39955

Clean up SceneDelegate

c849430

Cleanup AppDelegate

4c3ff95

Clean up notification handling

a64ed00

Delete ZMUserSession.didFinishLaunching and call `startEphemeralTim…

53719b6

…ers()` directly

Pass UIScene.ConnectionOptions through to SessionManager

492154c

Launch options are nil when app is configured for scenes

Delete AppDelegate.LaunchOptions

8a8882e

Update CallQualityController.getter:canPresentCallQualitySurvey to …

aea7a95

…rely on UIApplication.applicationState

Don't use launchType in SoundEventListener

de1f03f

This `launchType == .push` code path is never reached.

Delete ApplicationLaunchType and related code

a7fb66a

Delete static Name.ZMUserSessionDidBecomeAvailable

59b1999

This notification is no longer observed

Make AppDelegate.getter:sceneDelegate optional

bca93a0

Make AppDelegate.getter:mainWindow optional.

58e7ecf

Introduce AppDependencies

202b57f

Improve logging when opening a URL

ec4ae1d

Lint & format

7f16604

Delete AppDelegate.appRootRouter

224b81e

github-actions Bot assigned samwyndham Jun 8, 2026

samwyndham commented Jun 8, 2026

View reviewed changes

Fix typo

b1c1d5a

samwyndham requested review from David-Henner and netbe June 8, 2026 15:57

Update snapshot tests

e12dbf3

netbe reviewed Jun 10, 2026

View reviewed changes

David-Henner approved these changes Jun 11, 2026

View reviewed changes

samwyndham requested a review from netbe June 24, 2026 09:50

Conversation

samwyndham commented Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Snapshot updates

Testing

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

samwyndham Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

samwyndham Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

datadog-wireapp Bot commented Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud Bot commented Jun 9, 2026

Quality Gate passed

Uh oh!

netbe left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

samwyndham Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

samwyndham Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

samwyndham commented Jun 8, 2026 •

edited

Loading

samwyndham Jun 8, 2026 •

edited

Loading

samwyndham Jun 8, 2026 •

edited

Loading

github-actions Bot commented Jun 8, 2026 •

edited

Loading

datadog-wireapp Bot commented Jun 8, 2026 •

edited

Loading

samwyndham Jun 10, 2026 •

edited

Loading

samwyndham Jun 10, 2026 •

edited

Loading