fix: blocked user sees conversation is blocked - WPB-24403#4835
Merged
Conversation
Contributor
Test Results – WireDomain 1 files 141 suites 14s ⏱️ Results for commit 20c368b. ♻️ This comment has been updated with latest results. |
Contributor
Test Results – WireSyncEngine1 135 tests 1 135 ✅ 1m 20s ⏱️ Results for commit 20c368b. ♻️ This comment has been updated with latest results. |
Contributor
Test Results – WireRequestStrategy968 tests 968 ✅ 44s ⏱️ Results for commit 20c368b. ♻️ This comment has been updated with latest results. |
Contributor
Test Results – Wire-iOS1 897 tests 1 870 ✅ 2m 42s ⏱️ Results for commit 20c368b. ♻️ This comment has been updated with latest results. |
samwyndham
approved these changes
Jun 16, 2026
…ios into fix/blocked-user-WPB-24403
caldrian
approved these changes
Jun 19, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue
When an other user is blocked, the user is removed from the 1:1 conversation's member. This was triggering some codepath that detects a 1:1 conversation with only the self member (= other user deleted account) and wiped the mls conversation locally.
This resulted visually in showing to the other user that the conversation was readonly.
Solution:
Testing
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: