Skip to content

fix: blocked user sees conversation is blocked - WPB-24403#4835

Merged
netbe merged 11 commits into
developfrom
fix/blocked-user-WPB-24403
Jun 22, 2026
Merged

fix: blocked user sees conversation is blocked - WPB-24403#4835
netbe merged 11 commits into
developfrom
fix/blocked-user-WPB-24403

Conversation

@netbe

@netbe netbe commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator
BugWPB-24403 [iOS] The blocked user no longer appears in the conversation list

Issue

When an other user is blocked, the user is removed from the 1:1 conversation's member. This was triggering some codepath that detects a 1:1 conversation with only the self member (= other user deleted account) and wiped the mls conversation locally.

This resulted visually in showing to the other user that the conversation was readonly.

Solution:

  • moved app version migration to 4.22 -- it should not be an issue upgrading.
  • Prevent the conversation to set its mlsStatus as invalid if there's a oneOnOneUser.
  • Align conversation UI on self user side (blocker's side) to other platform: hide the input bar and show "You blocked this user"

Testing

  1. user A blocks an external user B
  2. check the conversation from user B side: user B can still send message but are not received
  3. user A sees the conversation with no input bar and a message "You blocked this user"

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@netbe netbe changed the title fix: blocked user sees he's blocked - WPB-24403 fix: blocked user sees conversation is blocked - WPB-24403 Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Test Results – WireDomain

  1 files  141 suites   14s ⏱️
564 tests 564 ✅ 0 💤 0 ❌
565 runs  565 ✅ 0 💤 0 ❌

Results for commit 20c368b.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Test Results – WireSyncEngine

1 135 tests   1 135 ✅  1m 20s ⏱️
  135 suites      0 💤
    1 files        0 ❌

Results for commit 20c368b.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Test Results – WireRequestStrategy

968 tests   968 ✅  44s ⏱️
108 suites    0 💤
  1 files      0 ❌

Results for commit 20c368b.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Test Results – Wire-iOS

1 897 tests   1 870 ✅  2m 42s ⏱️
  301 suites     27 💤
    1 files        0 ❌

Results for commit 20c368b.

♻️ This comment has been updated with latest results.

@datadog-wireapp

datadog-wireapp Bot commented Jun 9, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ede118b | Docs | Give us feedback!

@netbe netbe requested review from a team, caldrian and samwyndham and removed request for a team June 11, 2026 07:28

@samwyndham samwyndham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@netbe netbe added this pull request to the merge queue Jun 22, 2026
Merged via the queue into develop with commit d335820 Jun 22, 2026
19 checks passed
@netbe netbe deleted the fix/blocked-user-WPB-24403 branch June 22, 2026 12:37
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants