fix: show skin tone reactions in message details#4875
Open
MohamadJaara wants to merge 1 commit into
Open
Conversation
|
Contributor
Test Results1 900 tests 1 873 ✅ 2m 34s ⏱️ Results for commit f1f469b. Summary: workflow run #27787378938 |
netbe
requested review from
a team,
jullianm and
netbe
and removed request for
a team
netbe
approved these changes
Jun 22, 2026
netbe
left a comment
netbe
left a comment
Collaborator
There was a problem hiding this comment.
LGTM:) please add a jira ticket though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes message details not showing reactions when the reaction emoji includes a skin tone modifier.
Why this happened
The conversation cell renders reactions directly from the stored reaction string, so emoji such as
🙌🏻are visible in the message bubble.The message details screen used a different path: it tried to resolve every reaction through
EmojiRepositorybefore creating the reactions section. Skin tone variants are valid reaction strings, but they are not necessarily present as exact entries in the emoji repository. When lookup failed, the data source dropped the reaction entirely, so the Reactions tab showed the empty state even though the message had reactions.How it was fixed
The message details data source now keeps valid reaction rows even when the emoji repository cannot resolve the exact reaction string.
For skin tone emoji, it falls back to looking up the base emoji after removing Fitzpatrick skin tone modifiers, so the UI can still show a localized emoji name while preserving the original reaction emoji in the header.
For unknown or newer emoji that are not in the repository at all, the data source now displays the raw emoji with the user count instead of hiding the reaction.
Tests
Added regression coverage for:
🙌🏻EmojiRepository, e.g.🫡