Skip to content

fix: update certificate button area - WPB-26158 🍒#4878

Open
github-actions[bot] wants to merge 1 commit into
developfrom
fix/update-certificate-button-area-WPB-26158-cherry-pick
Open

fix: update certificate button area - WPB-26158 🍒#4878
github-actions[bot] wants to merge 1 commit into
developfrom
fix/update-certificate-button-area-WPB-26158-cherry-pick

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

This PR was automatically cherry-picked based on the following PR:

Original PR description:


Issue

The "Get Certificate" and "Update Certificate" buttons in DeviceDetailsButtonsView have a tap area limited to the text width, making them difficult to tap.

Cause

The button labels were not configured to expand to the full row width, so only the text itself was interactive.

Solution

Wrap each button label in an HStack with a Spacer, set .frame(maxWidth: .infinity), and apply .contentShape(Rectangle()) to make the full row area tappable.

Testing

  1. Open device details for a device eligible for E2EI certificate enrollment or update
  2. Tap to the right of the certificate button text
  3. Verify the button action triggers

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant