fix: update certificate button area - WPB-26158 🍒#4878
Open
github-actions[bot] wants to merge 1 commit into
Open
fix: update certificate button area - WPB-26158 🍒#4878github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR was automatically cherry-picked based on the following PR:
Original PR description:
Issue
The "Get Certificate" and "Update Certificate" buttons in
DeviceDetailsButtonsViewhave a tap area limited to the text width, making them difficult to tap.Cause
The button labels were not configured to expand to the full row width, so only the text itself was interactive.
Solution
Wrap each button label in an
HStackwith aSpacer, set.frame(maxWidth: .infinity), and apply.contentShape(Rectangle())to make the full row area tappable.Testing
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: