fix: prevent main app from blocking notification extension (take 4) - WPB-23511#4880
fix: prevent main app from blocking notification extension (take 4) - WPB-23511#4880samwyndham wants to merge 27 commits into
Quality Gate passed
Annotations
Check warning on line 80 in wire-ios/Wire-iOS Tests/AppBackgroundTaskExecuterTests.swift
sonarqubecloud / SonarCloud Code Analysis
Remove backticks (`) from "ends the background task after the operation succeeds" and rename it.
See more on https://sonarcloud.io/project/issues?id=wireapp_wire-ios&issues=AZ7vxE-_tqcQ6bfjhVRK&open=AZ7vxE-_tqcQ6bfjhVRK&pullRequest=4880
Check failure on line 34 in wire-ios-system/Source/BackgroundTasks.swift
sonarqubecloud / SonarCloud Code Analysis
Add a nested comment explaining why this function is empty, or complete the implementation.
See more on https://sonarcloud.io/project/issues?id=wireapp_wire-ios&issues=AZ7uMNTDJNFggkdXA2o4&open=AZ7uMNTDJNFggkdXA2o4&pullRequest=4880
Check warning on line 183 in WireDomain/Sources/WireDomain/Synchronization/IncrementalSync.swift
sonarqubecloud / SonarCloud Code Analysis
Refactor this code to not nest more than 2 closure expressions.
See more on https://sonarcloud.io/project/issues?id=wireapp_wire-ios&issues=AZ7uMNO0JNFggkdXA2o2&open=AZ7uMNO0JNFggkdXA2o2&pullRequest=4880
Check warning on line 42 in wire-ios/Wire-iOS Tests/AppBackgroundTaskExecuterTests.swift
sonarqubecloud / SonarCloud Code Analysis
Remove backticks (`) from "returns the operation's result" and rename it.
See more on https://sonarcloud.io/project/issues?id=wireapp_wire-ios&issues=AZ7vxE-_tqcQ6bfjhVRG&open=AZ7vxE-_tqcQ6bfjhVRG&pullRequest=4880
Check warning on line 93 in wire-ios/Wire Notification Service Extension/NotificationService.swift
sonarqubecloud / SonarCloud Code Analysis
Remove the unused function parameter "request" or name it "_".
See more on https://sonarcloud.io/project/issues?id=wireapp_wire-ios&issues=AZ7uMNMnJNFggkdXA2o1&open=AZ7uMNMnJNFggkdXA2o1&pullRequest=4880
Check warning on line 51 in wire-ios/Wire-iOS Tests/AppBackgroundTaskExecuterTests.swift
sonarqubecloud / SonarCloud Code Analysis
Remove backticks (`) from "rethrows the operation's error" and rename it.
See more on https://sonarcloud.io/project/issues?id=wireapp_wire-ios&issues=AZ7vxE-_tqcQ6bfjhVRH&open=AZ7vxE-_tqcQ6bfjhVRH&pullRequest=4880
Check warning on line 133 in wire-ios/Wire-iOS Tests/AppBackgroundTaskExecuterTests.swift
sonarqubecloud / SonarCloud Code Analysis
Refactor this code to not nest more than 2 closure expressions.
See more on https://sonarcloud.io/project/issues?id=wireapp_wire-ios&issues=AZ7vxE-_tqcQ6bfjhVRO&open=AZ7vxE-_tqcQ6bfjhVRO&pullRequest=4880
Check warning on line 94 in wire-ios/Wire-iOS Tests/AppBackgroundTaskExecuterTests.swift
sonarqubecloud / SonarCloud Code Analysis
Remove backticks (`) from "ends the background task even when the operation throws" and rename it.
See more on https://sonarcloud.io/project/issues?id=wireapp_wire-ios&issues=AZ7vxE-_tqcQ6bfjhVRL&open=AZ7vxE-_tqcQ6bfjhVRL&pullRequest=4880
Check warning on line 108 in wire-ios/Wire-iOS Tests/AppBackgroundTaskExecuterTests.swift
sonarqubecloud / SonarCloud Code Analysis
Remove backticks (`) from "firing the expiration handler cancels the operation" and rename it.
See more on https://sonarcloud.io/project/issues?id=wireapp_wire-ios&issues=AZ7vxE-_tqcQ6bfjhVRM&open=AZ7vxE-_tqcQ6bfjhVRM&pullRequest=4880
Check failure on line 37 in wire-ios/Wire-iOS Tests/AppBackgroundTaskExecuterTests.swift
sonarqubecloud / SonarCloud Code Analysis
Add a nested comment explaining why this closure is empty, or complete the implementation.
See more on https://sonarcloud.io/project/issues?id=wireapp_wire-ios&issues=AZ7vxE-_tqcQ6bfjhVRF&open=AZ7vxE-_tqcQ6bfjhVRF&pullRequest=4880
Check warning on line 135 in wire-ios/Wire-iOS Tests/AppBackgroundTaskExecuterTests.swift
sonarqubecloud / SonarCloud Code Analysis
Refactor this code to not nest more than 2 closure expressions.
See more on https://sonarcloud.io/project/issues?id=wireapp_wire-ios&issues=AZ7vxE-_tqcQ6bfjhVRP&open=AZ7vxE-_tqcQ6bfjhVRP&pullRequest=4880
Check warning on line 126 in wire-ios/Wire-iOS Tests/AppBackgroundTaskExecuterTests.swift
sonarqubecloud / SonarCloud Code Analysis
Remove backticks (`) from "external cancellation cancels the operation and ends the background task" and rename it.
See more on https://sonarcloud.io/project/issues?id=wireapp_wire-ios&issues=AZ7vxE-_tqcQ6bfjhVRN&open=AZ7vxE-_tqcQ6bfjhVRN&pullRequest=4880
Check warning on line 39 in wire-ios-share-engine/Sources/StrategyFactory.swift
sonarqubecloud / SonarCloud Code Analysis
Initializer has 8 parameters, which is greater than the 7 authorized.
See more on https://sonarcloud.io/project/issues?id=wireapp_wire-ios&issues=AZ7uMNS5JNFggkdXA2o3&open=AZ7uMNS5JNFggkdXA2o3&pullRequest=4880
Check warning on line 37 in wire-ios-system/Source/BackgroundTasks.swift
sonarqubecloud / SonarCloud Code Analysis
Remove the unused function parameter "name" or name it "_".
See more on https://sonarcloud.io/project/issues?id=wireapp_wire-ios&issues=AZ7uqIIiKHrHClpiGWIA&open=AZ7uqIIiKHrHClpiGWIA&pullRequest=4880
Check warning on line 98 in wire-ios-sync-engine/Source/Synchronization/StrategyDirectory.swift
sonarqubecloud / SonarCloud Code Analysis
Remove the unused function parameter "searchUsersCache" or name it "_".
See more on https://sonarcloud.io/project/issues?id=wireapp_wire-ios&issues=AZ7uMNDnJNFggkdXA2o0&open=AZ7uMNDnJNFggkdXA2o0&pullRequest=4880
Check warning on line 60 in wire-ios/Wire-iOS Tests/AppBackgroundTaskExecuterTests.swift
sonarqubecloud / SonarCloud Code Analysis
Remove backticks (`) from "passes the provided name to beginBackgroundTask" and rename it.
See more on https://sonarcloud.io/project/issues?id=wireapp_wire-ios&issues=AZ7vxE-_tqcQ6bfjhVRI&open=AZ7vxE-_tqcQ6bfjhVRI&pullRequest=4880
Check warning on line 70 in wire-ios/Wire-iOS Tests/AppBackgroundTaskExecuterTests.swift
sonarqubecloud / SonarCloud Code Analysis
Remove backticks (`) from "defaults a nil name to "unnamed"" and rename it.
See more on https://sonarcloud.io/project/issues?id=wireapp_wire-ios&issues=AZ7vxE-_tqcQ6bfjhVRJ&open=AZ7vxE-_tqcQ6bfjhVRJ&pullRequest=4880
Check failure on line 206 in wire-ios/Tests/Sourcery/generated/AutoMockable.generated.swift
sonarqubecloud / SonarCloud Code Analysis
Add a nested comment explaining why this function is empty, or complete the implementation.
See more on https://sonarcloud.io/project/issues?id=wireapp_wire-ios&issues=AZ7vxFE_tqcQ6bfjhVRQ&open=AZ7vxFE_tqcQ6bfjhVRQ&pullRequest=4880