Skip to content

fix(ClientRouter): pass location.href as base to new URL() in GET for… #16910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jettwayio wants to merge 3 commits into from
Closed

fix(ClientRouter): pass location.href as base to new URL() in GET for… #16910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d3a345
fix(ClientRouter): pass location.href as base to new URL() in GET for…
jettwayio May 29, 2026
cb8f1f9
Create explicit-form-base-action.md
jettwayio May 29, 2026
214f933
Merge branch 'main' into patch-3
jettwayio Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hot-brooms-sleep.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"astro": patch
---

Fix TypeError when a GET form uses a relative `formaction` attribute with ClientRouter enabled
2 changes: 1 addition & 1 deletion packages/astro/components/ClientRouter.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ const { fallback = 'animate' } = Astro.props;
const options: Options = { sourceElement: submitter ?? form };
if (method === 'get') {
const params = new URLSearchParams(formData as any);
const url = new URL(action);
const url = new URL(action, location.href);
url.search = params.toString();
action = url.toString();
} else {
Expand Down
Loading