fix: remove dead else branch in csp insertDirective

[stefanmachhammer]

Description

Simplifies the insertDirective method returned by context.csp (in packages/astro/src/core/fetch/fetch-state.ts).

The previous implementation had a misleading else branch:

insertDirective(payload) {
  if (state?.result?.directives) {
    state.result.directives = pushDirective(state.result.directives, payload);
  } else {
    state?.result?.directives.push(payload);
  }
},

Two problems:

1. Dead code. state.result.directives is always initialized to an array (see fetch-state.ts:407 — directives: manifest.csp?.directives ? [...manifest.csp.directives] : []). Because empty arrays are truthy in JS, the if branch fires whenever state.result exists. The else is unreachable in practice.
2. The else would crash if reached. Calling .push on the value that the if-condition just established is nullish would throw a TypeError. The optional-chaining ?. doesn't help — it only short-circuits up through state?.result?, not the final .push call.

This PR replaces both branches with the same single-statement pattern used by the sibling insertScriptResource / insertStyleResource methods directly below it.

Testing

Pure refactor of unreachable code; behavior under all currently-reachable inputs (i.e. whenever state.result exists, which is the only state the existing if-branch matches) is unchanged.

Docs

Not user-visible; no docs changes needed.

Changeset

Included.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 05b63d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[codspeed-hq]

Merging this PR will not alter performance

✅ 18 untouched benchmarks

---

_{Comparing stefanmachhammer:fix/csp-insert-directive-dead-else (05b63d0) with main (79c6c46)¹}

Footnotes

1. No successful run was found on main (e8fe0f5) during the generation of this report, so 79c6c46 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[ematipico]

Good catch. I removed the changeset because it doesn't change any public API