Skip to content

RFC: Add blob feature #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eibach wants to merge 7 commits into
base: master
Choose a base branch
from
Open

RFC: Add blob feature #938

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d8ea926
Add blob feature
eibach Dec 3, 2024
1aeb661
Use correct constructor for StringData
eibach Dec 3, 2024
f134e06
Add client side fragmented blob support
eibach Dec 9, 2024
66286b4
Added missing tracy::
JCash Dec 1, 2024
cf25503
Use uint32_t for blob size
eibach Dec 10, 2024
d476f27
Properly limit blob fragment size
eibach Dec 10, 2024
198b732
Add infrastructure for fragmented blobs
eibach Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions profiler/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ set(SERVER_FILES
TracyUtility.cpp
TracyView.cpp
TracyView_Annotations.cpp
TracyView_Blobs.cpp
TracyView_Callstack.cpp
TracyView_Compare.cpp
TracyView_ConnectionState.cpp
Expand Down
3 changes: 3 additions & 0 deletions profiler/src/profiler/TracyView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -900,6 +900,8 @@ bool View::DrawImpl()
ImGui::SameLine();
ToggleButton( ICON_FA_TAGS " Messages", m_showMessages );
ImGui::SameLine();
ToggleButton( ICON_FA_CUBE " Blobs", m_showBlobs );
ImGui::SameLine();
ToggleButton( ICON_FA_MAGNIFYING_GLASS " Find", m_findZone.show );
ImGui::SameLine();
ToggleButton( ICON_FA_ARROW_UP_WIDE_SHORT " Statistics", m_showStatistics );
Expand Down Expand Up @@ -1132,6 +1134,7 @@ bool View::DrawImpl()

if( m_showOptions ) DrawOptions();
if( m_showMessages ) DrawMessages();
if( m_showBlobs ) DrawBlobs();
if( m_showFlameGraph ) DrawFlameGraph();
if( m_findZone.show ) DrawFindZone();
if( m_showStatistics ) DrawStatistics();
Expand Down
23 changes: 23 additions & 0 deletions profiler/src/profiler/TracyView.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,8 @@ class View
void DrawOptions();
void DrawMessages();
void DrawMessageLine( const MessageData& msg, bool hasCallstack, int& idx );
void DrawBlobs();
void DrawBlobLine( const BlobData& msg, bool hasCallstack, int& idx );
void DrawFindZone();
void AccumulationModeComboBox();
void DrawStatistics();
Expand Down Expand Up @@ -387,6 +389,7 @@ class View
void UpdateTitle();

unordered_flat_map<uint64_t, bool> m_visibleMsgThread;
unordered_flat_map<uint64_t, bool> m_visibleBlobThread;
unordered_flat_map<uint64_t, bool> m_waitStackThread;
unordered_flat_map<uint64_t, bool> m_flameGraphThread;
unordered_flat_map<const void*, int> m_gpuDrift;
Expand All @@ -405,6 +408,16 @@ class View
return it->second;
}

tracy_force_inline bool& VisibleBlobThread( uint64_t thread )
{
auto it = m_visibleBlobThread.find( thread );
if( it == m_visibleBlobThread.end() )
{
it = m_visibleBlobThread.emplace( thread, true ).first;
}
return it->second;
}

tracy_force_inline bool& WaitStackThread( uint64_t thread )
{
auto it = m_waitStackThread.find( thread );
Expand Down Expand Up @@ -460,8 +473,11 @@ class View
LockHighlight m_lockHighlight { -1 };
LockHighlight m_nextLockHighlight;
DecayValue<const MessageData*> m_msgHighlight = nullptr;
DecayValue<const BlobData*> m_blobHighlight = nullptr;
DecayValue<uint32_t> m_lockHoverHighlight = InvalidId;
DecayValue<const MessageData*> m_msgToFocus = nullptr;
DecayValue<const BlobData*> m_blobToFocus = nullptr;
DecayValue<const BlobData*> m_blobSelected = nullptr;
const GpuEvent* m_gpuInfoWindow = nullptr;
const GpuEvent* m_gpuHighlight;
uint64_t m_gpuInfoWindowThread;
Expand All @@ -478,11 +494,17 @@ class View
int m_frameHover = -1;
bool m_messagesScrollBottom;
ImGuiTextFilter m_messageFilter;
bool m_blobsScrollBottom;
ImGuiTextFilter m_blobFilter;
bool m_showMessageImages = false;
int m_visibleMessages = 0;
size_t m_prevMessages = 0;
bool m_messagesShowCallstack = false;
Vector<uint32_t> m_msgList;
int m_visibleBlobs = 0;
size_t m_prevBlobs = 0;
bool m_blobsShowCallstack = false;
Vector<uint32_t> m_blobList;
bool m_disconnectIssued = false;
DecayValue<uint64_t> m_drawThreadMigrations = 0;
DecayValue<uint64_t> m_drawThreadHighlight = 0;
Expand All @@ -505,6 +527,7 @@ class View

bool m_showOptions = false;
bool m_showMessages = false;
bool m_showBlobs = false;
bool m_showStatistics = false;
bool m_showInfo = false;
bool m_showPlayback = false;
Expand Down
Loading