wip: fast-forward buffered streaming + async task cancellation safety + lock free state#468
Draft
0xOsiris wants to merge 3 commits into
Draft
wip: fast-forward buffered streaming + async task cancellation safety + lock free state#4680xOsiris wants to merge 3 commits into
0xOsiris wants to merge 3 commits into
Conversation
Contributor
Benchmark ResultsCompared on the same runner in the same workflow run.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Reworks the flashblock execution pipeline to use per-epoch async processors and broadcast-driven notifications, which can change ordering/cancellation semantics and impact pending-block/payload propagation under load.
Overview
Refactors flashblock execution from a single, coordinator-owned state machine into an epoch-scoped processing model:
run_flashblock_processornow detectspayload_idboundaries, spawns aPendingPayloadProcessorper epoch, and cancels the previous epoch by dropping its broadcast sender.Adds a new
processormodule that centralizes pending-block mutations and payload event broadcasting viaPendingBlockNotification, and updates the coordinator’s local-payload publish path to notify this processor after P2P broadcast.Updates the builder APIs (
BlockBuilderExt) and executors to support new plumbing (new trait hooks, committed-state construction helper), and adjusts benchmarks/dependencies (addstokio-streamandop-alloy-rpc-types-engine) to drive the new stream-based processor path.Written by Cursor Bugbot for commit dad6f1f. Configure here.