chore: profiling harness#478
Open
0xOsiris wants to merge 3 commits into
Open
Conversation
0xOsiris
requested review from
0xForerunner,
Dzejkop,
alessandromazza98,
cichaczem,
karankurbur,
kilianglas,
murph and
piohei
as code owners
![semgrep-code-worldcoin[bot]](https://avatars.githubusercontent.com/u/60940476?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is kicking off a free cloud agent to fix this issue. This run is complimentary, but you can enable autofix for all future PRs in the Cursor dashboard.
Contributor
Benchmark ResultsCompared on the same runner in the same workflow run.
|
alessandromazza98
requested changes
May 5, 2026
| RUSTFLAGS="-Cprofile-generate=$PGO_DATA_DIR -C target-cpu=native $EXTRA_RUSTFLAGS" \ | ||
| cargo bench --profile "$PROFILE_BUILD" \ | ||
| --package world-chain-builder \ | ||
| --bench coordinator \ |
Contributor
There was a problem hiding this comment.
there is no coordinator bench
Contributor
There was a problem hiding this comment.
There are:
help: available bench targets:
flashblock_building_live_node
flashblock_validation_live_node
flashblock_validation_synthetic
What was previuously called coordinator is now called flashblock_validation_synthetic
Contributor
There was a problem hiding this comment.
I'd suggest live node benches though as they are more reliable and mimic more closely mainnet behaviours
| b = "bench --package builder --bench coordinator --" | ||
| bs = "bench --package builder --bench coordinator -- --save-baseline" | ||
| bc = "bench --package builder --bench coordinator -- --baseline main --save-baseline pr" | ||
| bench = "bench --package builder --bench coordinator --" |
Contributor
There was a problem hiding this comment.
same here and below, there is no coordinator bench
| RUSTFLAGS="-Cprofile-generate=/tmp/pgo-data -C target-cpu=native" \ | ||
| cargo bench --profile profiling \ | ||
| --package world-chain-builder \ | ||
| --bench coordinator \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Mostly adds build/CI automation for profiling and PGO and introduces a new
profilingcargo profile; runtime behavior is unchanged but build configuration and dependency graph may affect compile times and reproducibility.Overview
Adds a profiling harness for
world-chain, including a newprofilingCargo profile (release-like with full debug symbols) pluscargo/justhelpers for native builds, profiling benchmarks, and profiling/maxperf Docker images.Introduces PGO automation via
Justfiletargets and a new.github/scripts/build_pgo.shscript to build instrumented binaries, collect.profrawvia benchmarks, merge to.profdata, and rebuild with profile use.Adds a new manually-triggered GitHub Actions workflow
profiling.ymlto build and upload profiling binaries (and optionally run the full PGO pipeline), and updates test-utils to includealloy-rpc-client(with the correspondingCargo.lockchange).Written by Cursor Bugbot for commit 8a937ae. Configure here.