Add reactive Anti-Magic Shell and Malkorok (DPS) encounter

.gitignore

@@ -25,6 +25,7 @@ package.json.tmp
 /mop/
 *.code-workspace
 wowsimmop
+wowsimmop.exe
 
 # old result file
 TestAPL.results

makefile

@@ -1,4 +1,14 @@
 OUT_DIR := dist/mop
+# On native Windows, air (and cmd.exe generally) can't launch a PE binary that's missing its
+# .exe extension -- it falls back to the "Select an app to open" file-association prompt instead
+# of just running it. Cross-compiled release builds already name their output
+# wowsimmop-windows.exe explicitly; this only affects the local dev build, which is otherwise
+# platform-agnostic.
+ifeq ($(OS),Windows_NT)
+	BIN_EXT := .exe
+else
+	BIN_EXT :=
+endif
 TS_CORE_SRC := $(shell find ui/core -name '*.ts' -type f)
 ASSETS_INPUT := $(shell find assets/ -type f)
 ASSETS := $(patsubst assets/%,$(OUT_DIR)/assets/%,$(ASSETS_INPUT))
@@ -74,6 +84,7 @@ clean:
 	rm -rf ui/core/proto/*.ts \
 	  sim/core/proto/*.pb.go \
 	  wowsimmop \
+	  wowsimmop.exe \
 	  wowsimmop-windows.exe \
 	  wowsimmop-amd64-darwin \
 	  wowsimmop-arm64-darwin \
@@ -175,7 +186,7 @@ wowsimmop: binary_dist devserver
 .PHONY: devserver
 devserver: sim/core/proto/api.pb.go sim/web/main.go binary_dist/dist.go
 	@echo "Starting server compile now..."
-	@if go build -o wowsimmop ./sim/web/main.go ; then \
+	@if go build -o wowsimmop$(BIN_EXT) ./sim/web/main.go ; then \
 		printf "\033[1;32mBuild Completed Successfully\033[0m\n"; \
 	else \
 		printf "\033[1;31mBUILD FAILED\033[0m\n"; \
@@ -194,9 +205,9 @@ endif
 rundevserver: air devserver
 ifeq ($(WATCH), 1)
 	npx tsx vite.build-workers.mts & npx vite build -m development --watch &
-	ulimit -n 10240 && air -tmp_dir "/tmp" -build.include_ext "go,proto" -build.args_bin "--usefs=true --launch=false" -build.bin "./wowsimmop" -build.cmd "make devserver" -build.exclude_dir "assets,dist,node_modules,ui,tools"
+	ulimit -n 10240 && air -tmp_dir "/tmp" -build.include_ext "go,proto" -build.args_bin "--usefs=true --launch=false" -build.bin "./wowsimmop$(BIN_EXT)" -build.cmd "make devserver" -build.exclude_dir "assets,dist,node_modules,ui,tools"
 else
-	./wowsimmop --usefs=true --launch=false --host=":3333"
+	./wowsimmop$(BIN_EXT) --usefs=true --launch=false --host=":3333"
 endif
 
 wowsimmop-windows.exe: wowsimmop
@@ -304,9 +315,9 @@ endif
 devmode: air devserver
 ifeq ($(WATCH), 1)
 	npx tsx vite.build-workers.mts & npx vite serve --host &
-	air -tmp_dir "/tmp" -build.include_ext "go,proto" -build.args_bin "--usefs=true --launch=false --wasm=false" -build.bin "./wowsimmop" -build.cmd "make devserver" -build.exclude_dir "assets,dist,node_modules,ui,tools"
+	air -tmp_dir "/tmp" -build.include_ext "go,proto" -build.args_bin "--usefs=true --launch=false --wasm=false" -build.bin "./wowsimmop$(BIN_EXT)" -build.cmd "make devserver" -build.exclude_dir "assets,dist,node_modules,ui,tools"
 else
-	./wowsimmop --usefs=true --launch=false --host=":3333"
+	./wowsimmop$(BIN_EXT) --usefs=true --launch=false --host=":3333"
 endif
 
 webworkers:

sim/death_knight/anti_magic_shell.go

@@ -143,16 +143,30 @@ func (dk *DeathKnight) registerAntiMagicShell() {
 		},
 	})
 
-	// When the user models AMS damage intake, autocast the shell as a low-priority DPS
-	// cooldown once Runic Power is nearly empty, so the RP from the absorbed magic damage
-	// tops the bar back up without overcapping. Registered only when intake is configured,
-	// so the shell stays out of the rotation entirely when the feature is disabled. It is
-	// cast through the autocastOtherCooldowns action present in every DPS preset.
+	// Autocast the shell as a low-priority DPS cooldown, cast through the
+	// autocastOtherCooldowns action present in every DPS preset. Only registered when the user
+	// has opted into damage-intake modeling (AvgAMSHit > 0): core.AddMajorCooldown has real side
+	// effects beyond just enabling ShouldActivate (it unconditionally ORs SpellFlagMCD onto the
+	// spell, sim/core/major_cooldown.go), which measurably changed Blood's golden-output tests
+	// even with ShouldActivate always returning false -- so this must stay a real conditional
+	// registration, not "always register but never activate."
+	//
+	// Reactive casting against a specific boss's real abilities (e.g. Malkorok) isn't handled
+	// here -- write it directly into the APL instead, using the existing "Boss Spell Is
+	// Casting" / "Boss Spell Time to Ready" condition nodes against that boss's SpellFlagAPL
+	// spells as a manual "Cast Spell" action (see ui/death_knight/blood/apls/iron_juggernaut.apl.json
+	// and the equivalent Frost/Unholy default rotations for the pattern). A manual "Cast Spell"
+	// action's APLActionCastSpell.IsReady never looks at ShouldActivate, so a user-authored
+	// reactive rule like that always takes priority over this flat heuristic.
 	if dk.Inputs.AvgAMSHit > 0 {
 		dk.AddMajorCooldown(core.MajorCooldown{
 			Spell:    antiMagicShellSpell,
 			Type:     core.CooldownTypeDPS,
 			Priority: core.CooldownPriorityLow,
+
+			ShouldActivate: func(sim *core.Simulation, character *core.Character) bool {
+				return dk.Inputs.AvgAMSHit > 0
+			},
 		})
 	}
 }