Add thumbprint user mapping support - #30
Conversation
- Allow to add thumbprint in AB:CD:EF... way - Allow to support wild card thumbprint - Allow to support wild card users
|
If we use just the CN to indicate issuer, config will be much clear.. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds thumbprint-to-user mapping support for mutual SSL authentication. It enables certificate-based authentication to validate username bindings against both certificate thumbprints and trusted issuers, providing more granular control over authentication authorization.
- Enhanced mutual SSL authenticator with thumbprint and issuer-based user mapping validation
- Added support for trusted issuer configuration and validation
- Implemented certificate binding validation with wildcard support
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
1uffyD9
left a comment
There was a problem hiding this comment.
We are currently reviewing the code change. Adding the concerns we found so far
1uffyD9
left a comment
There was a problem hiding this comment.
We are currently reviewing the code change. Adding the concerns we found so far
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Proposed changes in this pull request
$subject
With this support, we need to add the thumbprint-user mapping as below in
deployment.tomlProvided the support for below configs
When authenticating a certificate, the system validates in the following order:
Certificate Thumbprint Check
Issuer Check (if thumbprint not matched)
Failure