Add normalizedRequestURI and authorizedScopes to the thread local - #319
Draft
asha15 wants to merge 3 commits into
Draft
Add normalizedRequestURI and authorizedScopes to the thread local#319asha15 wants to merge 3 commits into
asha15 wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #319 +/- ##
============================================
- Coverage 10.84% 10.82% -0.02%
Complexity 49 49
============================================
Files 36 36
Lines 1651 1653 +2
Branches 279 279
============================================
Hits 179 179
- Misses 1458 1460 +2
Partials 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
19 tasks
piraveena
reviewed
Jun 6, 2025
| if (!ArrayUtils.contains(allowedScopes, scope)) { | ||
| granted = false; | ||
| break; | ||
| for (String requiredScope : authorizationContext.getRequiredScopes()) { |
asha15
marked this pull request as draft
July 13, 2025 15:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
This PR introduces the following enhancements to support fine-grained scope validation:
Related PR:
When should this PR be merged
[Please describe any preconditions that need to be addressed before we
can merge this pull request.]
Follow up actions
[List any possible follow-up actions here; for instance, testing data
migrations, software that we need to install on staging and production
environments.]
Checklist (for reviewing)
General
Functionality
Code
Tests
Security
Documentation