[rksk]

Purpose

In dual-write mode, uploading an attachment to an incident returned HTTP 400. Incident, change request and conversation uploads were sent to the mirrored data source and then a case attachment row keyed by the work item id was inserted, which violates the case foreign key. The file existed in the mirrored source but the caller saw an error. Listing attachments for these types read a synced table whose sync is stopped, so new uploads never appeared.

Goals

Creating and listing attachments for incident, change request and conversation works in dual-write mode.

Approach

Added one helper, isMirrorOnlyAttachmentRef, covering deployment plus the three non-case work item types. In dual-write mode, create uploads to the mirrored source only (no actor resolution, no Postgres insert) and returns its response, and search reads from the mirrored source. Plain postgres mode and case behaviour are unchanged. This is a temporary stopgap until Postgres-backed attachment storage for non-case work items exists, at which point the helper's non-deployment arms should be removed. Diff: 4 files, +118/-11, entity-service only. Update and delete behaviour are not changed.

User stories

N/A: bug fix.

Release note

Fixed attachment upload and listing for incidents, change requests and conversations in dual-write mode.

Documentation

N/A: no documented behaviour change.

Training

N/A: no training impact.

Certification

N/A: no impact on certification exams.

Marketing

N/A: bug fix.

Automation tests

• Unit tests

  Added/updated in internal/service: dual-write create for incident, change_request and conversation calls the mirror only (repo insert and actor resolution never reached) and returns mirror errors unchanged; case create still resolves the actor, uploads and inserts (existing test); plain postgres incident create still returns the validation error; search for the three types goes to the mirror in dual-write and to the repository in plain postgres. go vet ./... and go test ./... -count=1 pass.

• Integration tests

  N/A: covered by service-level unit tests with stubbed repository and mirror.

Security checks

• Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes
• Ran FindSecurityBugs plugin and verified report? N/A: Go service
• Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes

Samples

N/A: no samples.

Related PRs

None.

Migrations (if applicable)

N/A: no schema changes.

Test environment

Go unit tests on macOS.

Learning

N/A: follows the existing deployment stopgap pattern.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 8 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: wso2-open-operations/cs-tools
• Branch: main
• File: .coderabbit.yaml
• Commit: 0454a67
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: f495d182-78ae-48fb-82e8-32437aafa369

Commits

Reviewing files that changed from the base of the PR and between 0454a67 and 45e6a9f.

Files selected for processing: 4

• entity-service/internal/service/case_attachment_dual_write_service.go
• entity-service/internal/service/case_attachment_dual_write_service_test.go
• entity-service/internal/service/case_attachment_service_test.go
• entity-service/internal/service/case_service.go

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}