chore: replace commons-lang with commons-lang3 due to vulnerability - #460
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (22)
📝 WalkthroughSummaryThis pull request updates the project to use Apache Commons Lang 3 (version 3.18.0) in place of the legacy Apache Commons Lang 2 library. The migration involves updating dependencies and imports throughout the codebase. ChangesDependency Updates:
Import Updates:
Specifically, the following utility class imports were updated:
All existing code logic and method usage remain unchanged, as the Commons Lang 3 library provides compatible implementations of these utility classes. Impact
WalkthroughThe pull request migrates the charon project from Apache Commons Lang 2 ( 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Could you please help me to get review on this PR? Thanks. @Malith-19 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #460 +/- ##
============================================
- Coverage 31.93% 31.93% -0.01%
Complexity 1112 1112
============================================
Files 137 137
Lines 13523 13525 +2
Branches 2589 2590 +1
============================================
Hits 4319 4319
- Misses 8666 8668 +2
Partials 538 538
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hi @simaysanli thank you for raising the PR. We will review your PR. |
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
left a comment
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/28147733157
Hi @simaysanli can you sign this License Cla here. PR is LGTM and once you sign it we can merge the PR. |
|
@Malith-19 @sadilchamishka thanks for review and approval. I signed it. Could you please help me to merge it? As a next step, do I need to create PR in product-is as well? |
Hi @simaysanli versions will be auto bumped in the product-is. If you meant to update the commans-lang dependency in product-is we have to first upgrade the commans-lang version in other product-is components first. |
|
@Malith-19 I raised this PR to use the commons-lang3 instead of commons-lang. Do we need this change in scope of problem as seen in PR description? |
Purpose
Problem is related to CVE-2025-48924. The
org.wso2.charonhas latest version ofcommons-langis v2.6 as seen in this maven repository. It causes a vulnerability. I saw that similar issue is also reported with this issue related tocommons-langversion.The issue is already reported in this link
Goals
The commons-lang is replaced with commons-lang3 v3.18.0 to fix security vulnerability
Approach
The usages of commons-lang are replaced with commons-lang3 in all files
User stories
Developer Checklist (Mandatory)
product-isissue to track any behavioral change or migration impact.Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning