feat: add traces_detail_by_time table and materialized view for enhanced trace data retrieval - #3093
Conversation
…ced trace data retrieval
WalkthroughAdds a ClickHouse table for time-partitioned trace span details and a materialized view that transforms eligible router root spans from ChangesTrace detail storage
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3093 +/- ##
==========================================
+ Coverage 62.37% 71.16% +8.79%
==========================================
Files 262 335 +73
Lines 31003 49389 +18386
Branches 0 6049 +6049
==========================================
+ Hits 19337 35146 +15809
- Misses 10158 14217 +4059
+ Partials 1508 26 -1482 🚀 New features to boost your workflow:
|
|
Is this a prep work? I only see new tables being added, where's the application logic? |
We create the tables and leave them for 30 days, so the data gets populated and after that we change the code to use these tables. |
There was a problem hiding this comment.
Claude Code Review
Claude Code Review is paused for this repository. To reconnect it, an admin of this repository's GitHub organization (or the account owner, for personal repositories) who can also manage your Claude organization's Code Review settings needs to re-link GitHub in Code Review settings. This is a one-time step.
Tip: disable this comment in your organization's Code Review settings.
Summary by CodeRabbit
Checklist