fix(demo): rebuild products_fg as clean products + productCount delta - #3108
Open
jvr545 wants to merge 1 commit into
Open
fix(demo): rebuild products_fg as clean products + productCount delta#3108jvr545 wants to merge 1 commit into
jvr545 wants to merge 1 commit into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
This comment has been minimized.
This comment has been minimized.
Router image scan passed✅ No security vulnerabilities found in image: |
jvr545
force-pushed
the
fix/align-products-fg-schema
branch
from
July 23, 2026 06:07
aeb0bee to
1079d6c
Compare
Contributor
WalkthroughChangesProduct query support
Employee fixture update
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
router - uncommitted changes detectedSeems like you forgot to commit some code. Possible causes:
Dirty files
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3108 +/- ##
===========================================
+ Coverage 48.81% 49.95% +1.14%
===========================================
Files 1130 247 -883
Lines 157426 30303 -127123
Branches 10880 0 -10880
===========================================
- Hits 76842 15138 -61704
+ Misses 78713 13604 -65109
+ Partials 1871 1561 -310 🚀 New features to boost your workflow:
|
jvr545
marked this pull request as ready for review
July 23, 2026 17:34
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebuild
products_fgsubgraph to be a clean copy ofproductswith only one addition:Employee.productCount: Int!Changes
schema.graphqlswith baseproducts(restore@cost/@listSizedirectives,Thingtype,sharedThings/slicedThings/searchThingsqueries)# dwedwedewSharedThings,SlicedThings,SearchThings)ProductCountvalueSchema delta (products_fg vs products)
type Employee @key(fields: "id") { id: Int! products: [ProductName!]! + productCount: Int! notes: String @override(from: "employees") }Test plan
go generatesucceedsgo build ./cmd/products_fgsucceeds_entitiesquery returnsproductCount: 5for Employee id 1Deploy reminder
After merge, redeploy Fly app
product-api-fsusingdemo/docker/products_fg.DockerfileLinear
Resolves MAR2-3879: Draft Cosmo PR: rebuild products_fg as 1-to-1 with products + productCount
Summary by CodeRabbit
firstandafterparameters.