chore: add hostname to profile export - #3117
Conversation
Router image scan passed✅ No security vulnerabilities found in image: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughChangesPyroscope tagging
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies" Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3117 +/- ##
===========================================
+ Coverage 48.81% 62.03% +13.22%
===========================================
Files 1130 262 -868
Lines 157426 30815 -126611
Branches 10880 0 -10880
===========================================
- Hits 76842 19116 -57726
+ Misses 78713 10186 -68527
+ Partials 1871 1513 -358
🚀 New features to boost your workflow:
|
|
|
||
| // Add default tags to the config | ||
| maps.Copy(r.pyroscopeConfig.Tags, pyroscope.RouterVersionTags(versioninfo.New(Version, Commit, Date))) | ||
| r.pyroscopeConfig.Tags["hostname"] = r.hostName |
There was a problem hiding this comment.
Can we make this router_hostname and also make it router_custom_modules below?
Pyroscope profiles are aggregated by tags, so essentially when we aggregate by federated graph id, we might end up seeing multiple profiles accumulated because multiple router instances use the same graph api token.
This PR adds hostname as an additional tag.
Summary by CodeRabbit
Checklist
Open Source AI Manifesto
This project follows the principles of the Open Source AI Manifesto. Please ensure your contribution aligns with its principles.