fix(auth): stop false OAuth2 no-credentials warning without --app#86
Merged
Conversation
The check used GetApp("") which never resolves the default app, so it always
warned when any other app had credentials. Resolve default_app correctly and
name that app in the warning.
m-rosinsky
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xurl auth oauth2without--appalways warned that the"default"app had no client credentials, even when the realdefault_app(e.g.app-2) already had them.GetApp(""), which is an empty-key map lookup and always returns nil, instead of resolvingdefault_app.Test plan
go test ./cli/ -count=1xurl auth oauth2with a credentialeddefault_appand no--app→ no false warningxurl auth oauth2when default app has no credentials but another app does → warning names the real default app