-
Notifications
You must be signed in to change notification settings - Fork 89
xmtp_mls: route Sender::NewMemberCommit through from_external_commit + envelope-timestamp plumbing #3668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tylerhawkes
wants to merge
1
commit into
tyler/qr-invite-l7-validator
Choose a base branch
from
tyler/qr-invite-l8-ingestion
base: tyler/qr-invite-l7-validator
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
xmtp_mls: route Sender::NewMemberCommit through from_external_commit + envelope-timestamp plumbing #3668
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 2 additions & 0 deletions
2
crates/xmtp_db/migrations/2026-06-09-000000-0000_add_epoch_entered_at_ns_to_groups/down.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| ALTER TABLE groups | ||
| DROP COLUMN epoch_entered_at_ns; |
8 changes: 8 additions & 0 deletions
8
crates/xmtp_db/migrations/2026-06-09-000000-0000_add_epoch_entered_at_ns_to_groups/up.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| -- XIP-82: the delivery-service envelope timestamp of the message by | ||
| -- which this client entered the current MLS epoch (the epoch's commit, | ||
| -- or the welcome for members added at that epoch). NULL means the group | ||
| -- has not advanced epoch since this column landed; readers fall back to | ||
| -- created_at_ns (the initial epoch). Consumed by the external-commit | ||
| -- validator's expire_in_ns staleness bound. | ||
| ALTER TABLE groups | ||
| ADD COLUMN epoch_entered_at_ns BIGINT; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Medium
encrypted_store/group.rs:109StoredGroup::epoch_entered_at_nsdefaults toNULLfor existing rows, butxmtp_welcome.rscreates groups withcreated_at_nsset to localnow_ns()rather than the welcome message's envelope timestamp. This causes pre-migration groups to measure XIP-82 staleness from local insertion time instead of the actual epoch-entry message time, so external commits may be incorrectly accepted or rejected until the group advances epoch.🚀 Reply "fix it for me" or copy this AI Prompt for your agent: