Skip to content

fix: parse decimal wallet send calls chain IDs#1795

Open
giwaov wants to merge 2 commits into
xmtp:mainfrom
giwaov:fix-wallet-send-calls-chain-id
Open

fix: parse decimal wallet send calls chain IDs#1795
giwaov wants to merge 2 commits into
xmtp:mainfrom
giwaov:fix-wallet-send-calls-chain-id

Conversation

@giwaov

@giwaov giwaov commented May 12, 2026

Copy link
Copy Markdown

Summary

  • parse wallet send calls chain IDs as hex only when they use the \

Note

Fix chain ID parsing in WalletSendCallsContent to handle decimal and hex strings

Adds a parseWalletSendCallsChainId helper in walletSendCalls.ts that parses chain IDs from either hex (0x...) or decimal string format. Previously, WalletSendCallsContent used parseInt(chainId, 16) unconditionally, causing incorrect chain IDs when the value was a decimal string. The handleSubmit callback dependency array is also updated to include switchChainAsync and wagmiChainId.

Macroscope summarized 6a73cdc.

@giwaov giwaov requested a review from a team as a code owner May 12, 2026 16:21
@changeset-bot

changeset-bot Bot commented May 12, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6a73cdc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@giwaov giwaov requested a review from a team as a code owner May 12, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant