Skip to content

fix: handle get_inbox_ids DM load errors#1800

Open
giwaov wants to merge 1 commit into
xmtp:mainfrom
giwaov:fix-handle-get-inbox-ids-dm-load
Open

fix: handle get_inbox_ids DM load errors#1800
giwaov wants to merge 1 commit into
xmtp:mainfrom
giwaov:fix-handle-get-inbox-ids-dm-load

Conversation

@giwaov

@giwaov giwaov commented May 13, 2026

Copy link
Copy Markdown

Summary

  • avoid rethrowing handled get_inbox_ids request failures from the DM loader
  • keep rethrowing unexpected DM loader errors for the error modal
  • add a regression helper test for the get_inbox_ids error classifier

Closes #1462

Testing

  • yarn workspace @xmtp/xmtp.chat test apps/xmtp.chat/src/helpers/errors.test.ts (fails locally: Couldn't find the node_modules state file - running an install might help)
  • git diff --check

Note

Fix get_inbox_ids DM load errors being rethrown to the error modal

When loading a DM fails due to a get_inbox_ids request error, the error is now swallowed after redirecting to home instead of being rethrown to the error modal. A new isGetInboxIdsRequestError helper in helpers/errors.ts detects these errors by matching both 'endpoint "get_inbox_ids"' and 'error sending request' in the error message. All other errors in LoadDM.tsx continue to be rethrown as before.

Macroscope summarized 68f9dee.

@giwaov giwaov requested review from a team as code owners May 13, 2026 10:37
@changeset-bot

changeset-bot Bot commented May 13, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 68f9dee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error Collection: "get_inbox_ids" has error error sending request

1 participant