Skip to content

chore: remove node-sdk + browser-sdk (migrated to libxmtp)#1827

Open
insipx wants to merge 1 commit into
mainfrom
insipx/teardown-migrated-sdks
Open

chore: remove node-sdk + browser-sdk (migrated to libxmtp)#1827
insipx wants to merge 1 commit into
mainfrom
insipx/teardown-migrated-sdks

Conversation

@insipx

@insipx insipx commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@xmtp/node-sdk and @xmtp/browser-sdk now live in the libxmtp monorepo and are published from there (verified: both publish from libxmtp with their native binding pinned to the version published in the same run). This removes them from xmtp-js and rewires the remaining consumers to the published npm versions.

Changes

  • Delete sdks/node-sdk, sdks/browser-sdk and their CI (.github/workflows/{node,browser}-sdk.yml).
  • release.yml: drop the node-sdk/browser-sdk prerelease options + the auto-prerelease-bindings detect/publish jobs (that automation now lives in libxmtp). Keep agent-sdk prerelease.
  • Rewire consumers to published npm:
    • apps/xmtp.chat@xmtp/browser-sdk@7.0.0-dev.b5cdc06 (the libxmtp dev build; the stable 7.0.0 predates the binding APIs xmtp.chat uses — fetchLatestInboxUpdatesCount, ContentTypeId.sameAs). Renovate tracks it for bumps.
    • sdks/agent-sdk + packages/xmtp-cli@xmtp/node-sdk@^6.0.0.
  • .yarnrc.yml: add @xmtp/browser-sdk to npmPreapprovedPackages so the freshly-published dev build clears the 7-day npmMinimalAgeGate (mirrors the other @xmtp/* SDKs already listed).
  • renovate.json: track @xmtp/node-sdk + @xmtp/browser-sdk.
  • Drop the orphaned node-sdk changeset; remove stale SDK path filters from content-types.yml / xmtp-chat.yml.
  • Regenerate yarn.lock.

Verification

agent-sdk, xmtp-cli, and xmtp.chat all build green against the published SDKs (yarn build topo order). The one full-build failure (xmtp.chat-api-service) is a pre-existing Prisma engine 404, unrelated to this change.

Follow-up (not in this PR)

sync-documentation.yml still has node-sdk/browser-sdk branches that no longer fire (those release tags now come from libxmtp, not xmtp-js). Left for the docs owner to delete or migrate the doc-sync to libxmtp.

🤖 Generated with Claude Code

Note

Remove node-sdk and browser-sdk from the monorepo after migration to libxmtp

  • Deletes the sdks/node-sdk test file and removes path triggers for sdks/node-sdk/src/** and sdks/browser-sdk/** from CI workflows, so those directories no longer drive builds or tests.
  • Strips node-sdk and browser-sdk release options from the release workflow, sets agent-sdk as the new default, and removes the auto-prerelease bindings jobs.
  • Pins apps/xmtp.chat to @xmtp/browser-sdk@7.0.0-dev.b5cdc06 (previously resolved from the workspace) and relaxes @xmtp/node-sdk to ^6.0.0 in xmtp-cli and agent-sdk.
  • Adds Renovate grouping for @xmtp/node-sdk and @xmtp/browser-sdk under an xmtp sdks group.
📊 Macroscope summarized f7efd00. 5 files reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted

🗂️ Filtered Issues

No issues evaluated.

@insipx insipx requested review from a team as code owners June 9, 2026 15:46
The @xmtp/node-sdk and @xmtp/browser-sdk packages now live in the libxmtp
monorepo and are published from there. Remove them from xmtp-js and rewire
the remaining consumers to the published npm versions.

- Delete sdks/node-sdk, sdks/browser-sdk and their CI workflows
  (.github/workflows/{node,browser}-sdk.yml).
- release.yml: drop the node-sdk/browser-sdk prerelease options + the
  auto-prerelease-bindings detect/publish jobs (that automation now lives
  in libxmtp); keep agent-sdk prerelease.
- Rewire consumers to published npm: apps/xmtp.chat -> browser-sdk
  7.0.0-dev.b5cdc06 (libxmtp dev build; the stable 7.0.0 predates the
  binding APIs xmtp.chat uses), sdks/agent-sdk + packages/xmtp-cli ->
  node-sdk ^6.0.0.
- .yarnrc.yml: add @xmtp/browser-sdk to npmPreapprovedPackages so the
  freshly-published dev build clears the 7-day npmMinimalAgeGate.
- renovate.json: track @xmtp/node-sdk + @xmtp/browser-sdk.
- Drop the orphaned node-sdk changeset; remove stale SDK path filters
  from content-types.yml and xmtp-chat.yml.
- Regenerate yarn.lock; agent-sdk, xmtp-cli and xmtp.chat all build.

Follow-up: sync-documentation.yml still has node/browser-sdk branches that
no longer fire (those release tags now come from libxmtp); left for the
docs owner to delete or migrate to libxmtp.
@insipx insipx force-pushed the insipx/teardown-migrated-sdks branch from 8b8e18e to f7efd00 Compare June 9, 2026 15:50
@changeset-bot

changeset-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f7efd00

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment thread renovate.json
Comment on lines +21 to +25
"matchPackageNames": ["@xmtp/node-sdk", "@xmtp/browser-sdk"],
"groupName": "xmtp sdks",
"groupSlug": "xmtp-sdks",
"commitMessageTopic": "xmtp sdks",
"rangeStrategy": "bump"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium renovate.json:21

The @xmtp/browser-sdk rule uses rangeStrategy: "bump" without prerelease settings, so Renovate will not upgrade apps/xmtp.chat from its pinned prerelease 7.0.0-dev.b5cdc06 to newer dev builds. The binding rule sets followTag: "nightly" and respectLatest: false, but the SDK rule lacks these, so Renovate will likely propose the stable 7.0.0 instead of newer prereleases that the app requires.

-      "rangeStrategy": "bump"
+      "followTag": "nightly",
+      "respectLatest": false,
+      "rangeStrategy": "bump"
🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file @renovate.json around lines 21-25:

The `@xmtp/browser-sdk` rule uses `rangeStrategy: "bump"` without prerelease settings, so Renovate will not upgrade `apps/xmtp.chat` from its pinned prerelease `7.0.0-dev.b5cdc06` to newer dev builds. The binding rule sets `followTag: "nightly"` and `respectLatest: false`, but the SDK rule lacks these, so Renovate will likely propose the stable `7.0.0` instead of newer prereleases that the app requires.

@macroscopeapp

macroscopeapp Bot commented Jun 9, 2026

Copy link
Copy Markdown

Approvability

Verdict: Needs human review

1 blocking correctness issue found. Diff is too large for automated approval analysis. A human reviewer should evaluate this PR.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant