chore: remove node-sdk + browser-sdk (migrated to libxmtp)#1827
Conversation
The @xmtp/node-sdk and @xmtp/browser-sdk packages now live in the libxmtp
monorepo and are published from there. Remove them from xmtp-js and rewire
the remaining consumers to the published npm versions.
- Delete sdks/node-sdk, sdks/browser-sdk and their CI workflows
(.github/workflows/{node,browser}-sdk.yml).
- release.yml: drop the node-sdk/browser-sdk prerelease options + the
auto-prerelease-bindings detect/publish jobs (that automation now lives
in libxmtp); keep agent-sdk prerelease.
- Rewire consumers to published npm: apps/xmtp.chat -> browser-sdk
7.0.0-dev.b5cdc06 (libxmtp dev build; the stable 7.0.0 predates the
binding APIs xmtp.chat uses), sdks/agent-sdk + packages/xmtp-cli ->
node-sdk ^6.0.0.
- .yarnrc.yml: add @xmtp/browser-sdk to npmPreapprovedPackages so the
freshly-published dev build clears the 7-day npmMinimalAgeGate.
- renovate.json: track @xmtp/node-sdk + @xmtp/browser-sdk.
- Drop the orphaned node-sdk changeset; remove stale SDK path filters
from content-types.yml and xmtp-chat.yml.
- Regenerate yarn.lock; agent-sdk, xmtp-cli and xmtp.chat all build.
Follow-up: sync-documentation.yml still has node/browser-sdk branches that
no longer fire (those release tags now come from libxmtp); left for the
docs owner to delete or migrate to libxmtp.
8b8e18e to
f7efd00
Compare
|
| "matchPackageNames": ["@xmtp/node-sdk", "@xmtp/browser-sdk"], | ||
| "groupName": "xmtp sdks", | ||
| "groupSlug": "xmtp-sdks", | ||
| "commitMessageTopic": "xmtp sdks", | ||
| "rangeStrategy": "bump" |
There was a problem hiding this comment.
🟡 Medium renovate.json:21
The @xmtp/browser-sdk rule uses rangeStrategy: "bump" without prerelease settings, so Renovate will not upgrade apps/xmtp.chat from its pinned prerelease 7.0.0-dev.b5cdc06 to newer dev builds. The binding rule sets followTag: "nightly" and respectLatest: false, but the SDK rule lacks these, so Renovate will likely propose the stable 7.0.0 instead of newer prereleases that the app requires.
- "rangeStrategy": "bump"
+ "followTag": "nightly",
+ "respectLatest": false,
+ "rangeStrategy": "bump"🚀 Reply "fix it for me" or copy this AI Prompt for your agent:
In file @renovate.json around lines 21-25:
The `@xmtp/browser-sdk` rule uses `rangeStrategy: "bump"` without prerelease settings, so Renovate will not upgrade `apps/xmtp.chat` from its pinned prerelease `7.0.0-dev.b5cdc06` to newer dev builds. The binding rule sets `followTag: "nightly"` and `respectLatest: false`, but the SDK rule lacks these, so Renovate will likely propose the stable `7.0.0` instead of newer prereleases that the app requires.
ApprovabilityVerdict: Needs human review 1 blocking correctness issue found. Diff is too large for automated approval analysis. A human reviewer should evaluate this PR. You can customize Macroscope's approvability policy. Learn more. |
@xmtp/node-sdkand@xmtp/browser-sdknow live in the libxmtp monorepo and are published from there (verified: both publish from libxmtp with their native binding pinned to the version published in the same run). This removes them from xmtp-js and rewires the remaining consumers to the published npm versions.Changes
sdks/node-sdk,sdks/browser-sdkand their CI (.github/workflows/{node,browser}-sdk.yml).release.yml: drop thenode-sdk/browser-sdkprerelease options + theauto-prerelease-bindingsdetect/publish jobs (that automation now lives in libxmtp). Keepagent-sdkprerelease.apps/xmtp.chat→@xmtp/browser-sdk@7.0.0-dev.b5cdc06(the libxmtp dev build; the stable7.0.0predates the binding APIs xmtp.chat uses —fetchLatestInboxUpdatesCount,ContentTypeId.sameAs). Renovate tracks it for bumps.sdks/agent-sdk+packages/xmtp-cli→@xmtp/node-sdk@^6.0.0..yarnrc.yml: add@xmtp/browser-sdktonpmPreapprovedPackagesso the freshly-published dev build clears the 7-daynpmMinimalAgeGate(mirrors the other@xmtp/*SDKs already listed).renovate.json: track@xmtp/node-sdk+@xmtp/browser-sdk.node-sdkchangeset; remove stale SDK path filters fromcontent-types.yml/xmtp-chat.yml.yarn.lock.Verification
agent-sdk,xmtp-cli, andxmtp.chatall build green against the published SDKs (yarn buildtopo order). The one full-build failure (xmtp.chat-api-service) is a pre-existing Prisma engine 404, unrelated to this change.Follow-up (not in this PR)
sync-documentation.ymlstill hasnode-sdk/browser-sdkbranches that no longer fire (those release tags now come from libxmtp, not xmtp-js). Left for the docs owner to delete or migrate the doc-sync to libxmtp.🤖 Generated with Claude Code
Note
Remove node-sdk and browser-sdk from the monorepo after migration to libxmtp
sdks/node-sdktest file and removes path triggers forsdks/node-sdk/src/**andsdks/browser-sdk/**from CI workflows, so those directories no longer drive builds or tests.node-sdkandbrowser-sdkrelease options from the release workflow, setsagent-sdkas the new default, and removes the auto-prerelease bindings jobs.apps/xmtp.chatto@xmtp/browser-sdk@7.0.0-dev.b5cdc06(previously resolved from the workspace) and relaxes@xmtp/node-sdkto^6.0.0inxmtp-cliandagent-sdk.@xmtp/node-sdkand@xmtp/browser-sdkunder anxmtp sdksgroup.📊 Macroscope summarized f7efd00. 5 files reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted
🗂️ Filtered Issues
No issues evaluated.