Skip to content

fix: register missing flags and add fee validation in xmtpd-cli #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alelpoan wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: register missing flags and add fee validation in xmtpd-cli #2007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c896b39
fix: update --target flag help text with all supported values
alelpoan May 25, 2026
9541964
fix: register --private-key flag in getPubKeyCommand
alelpoan May 25, 2026
2809d0b
fix: validate fees are non-negative in addRatesHandler
alelpoan May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cmd/xmtpd-cli/commands/key_management.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@ xmtpd-cli keys get-public-key --private-key <private-key>
`,
}

cmd.Flags().String("private-key", "", "Private key (hex) to derive public key from")
_ = viper.BindPFlag("private-key", cmd.Flags().Lookup("private-key"))

return &cmd
}

Expand Down
4 changes: 4 additions & 0 deletions cmd/xmtpd-cli/commands/rate_registry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,10 @@ func addRatesHandler(opts AddRatesOpts) error {
return fmt.Errorf("could not build logger: %w", err)
}

if opts.MessageFee < 0 || opts.StorageFee < 0 || opts.CongestionFee < 0 {
return errors.New("fees cannot be negative")
}

ctx, cancel := context.WithDeadline(context.Background(), time.Now().Add(15*time.Second))
defer cancel()

Expand Down
2 changes: 1 addition & 1 deletion cmd/xmtpd-cli/commands/version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func getVersionCmd() *cobra.Command {
},
}
cmd.Flags().
Var(&target, "target", "settlement-chain-gateway|payer-registry|distribution-manager")
Var(&target, "target", "settlement-chain-gateway|payer-registry|distribution-manager|settlement-parameter-registry|payer-report-manager|rate-registry|group|identity|app-chain-gateway|app-parameter-registry|node-registry")
_ = cmd.MarkFlagRequired("target")
return cmd
}
Expand Down