Correction: left argument to decode for seconds to days/hours... - #31
Open
jonocarroll wants to merge 1 commit into
Open
Correction: left argument to decode for seconds to days/hours...#31jonocarroll wants to merge 1 commit into
jonocarroll wants to merge 1 commit into
Conversation
Author
|
Funnily enough, this timely video explains the "no overflow to a higher unit" behind the 0 https://youtu.be/hQFMjRPFioI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this resource, I'm very much enjoying reading it and following along on tryapl.org
I wanted to try my own version for the decode example and was confused that
9e4seconds (exactly 25 hours) produced0 1 0 0. The left argument of the decode should (I believe) be0 24 60 60in which case the result is, as expected,1 1 0 0.For the example you used (
1e4) it didn't matter, but trying a number greater than86399(1 day or larger) will give the wrong answer.I don't think it matters for the example following (both vectors produce the same results) but for consistency, I changed that, too.
As for why that should be
0and not1- an explanation of that would be wonderful because I'm not entirely sure I understand it.