The About box credits a translator by email and a year range the engine dropped - #172
Merged
Conversation
…ne dropped about_credits is our own hand-maintained copy of the engine's LANG_K1, run once through build_strings.sh and checked in; nothing regenerates it, so it has sat at the pre-2003 roster while the engine moved on. It still prints a contributor's personal email address, which httrack #1453 deliberately removed, and a 1998-<year> range that build_strings.sh was rewriting on every run. Mirrors LANG_K1 at engine 4055ba5a, including that script's (C) -> © rewrite, so a future regeneration produces the same text. The other two roster surfaces need no change here: greetings.txt is bundled from the pinned engine by buildResourcesBundle and html/index.html links it and contact.html, so both follow the next submodule bump on their own. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
The string edit went through a text-mode read and write, which rewrote all 253 terminators and buried a one-line change in a 506-line diff. The file is CRLF and stays CRLF; the content is unchanged from the previous commit. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The About box still prints a contributor's personal email address and a copyright year range, both of which the engine dropped in httrack #1453.
about_creditsis our own hand-maintained copy of the engine'sLANG_K1: it was run throughbuild_strings.shonce and checked in, and nothing regenerates it, so it has sat at the old roster while the engine moved on. This mirrorsLANG_K1at engine 4055ba5a, including that script's(C)to©rewrite, so a later regeneration produces the same text.Nothing else on the Android side needs changing.
greetings.txtis bundled from the pinned engine bybuildResourcesBundle, andhtml/index.htmllinks both it andcontact.html, so those roster surfaces follow the next submodule bump on their own.LANGUAGE_AUTHORis deliberately not rendered: the merged engine change leaves each catalog's own credit in place, so adding it would print a second credit beside the existing one.