Skip to content

warp: let the thread manager own the connections (#1126) #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kazu-yamamoto wants to merge 34 commits into
base: master
Choose a base branch
from
+492 −80
Open

warp: let the thread manager own the connections (#1126) #1128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
bbf5a8a
Let the thread manager own the connections
kazu-yamamoto Oct 9, 2026
7d42e6a
Say when a managed thread becomes managed
kazu-yamamoto Oct 9, 2026
5cd2412
ChangeLog: a title and a link
kazu-yamamoto Oct 9, 2026
7857efe
ChangeLog: link this PR
kazu-yamamoto Oct 9, 2026
dca185c
Kill a thread that is managed only after the manager stopped
kazu-yamamoto Oct 17, 2026
e8ed5ed
Let the refusal to record a thread end it quietly
kazu-yamamoto Oct 17, 2026
2c63c6a
Keep a thread recorded until its cleanup is done
kazu-yamamoto Oct 17, 2026
900c51e
Stop saying the threads are gone when they were only told
kazu-yamamoto Oct 17, 2026
378d296
Say what stopAfter does about a place still being kept
kazu-yamamoto Oct 17, 2026
c835778
Correct the reason a thread cannot be registered before it starts
kazu-yamamoto Oct 17, 2026
d9396b9
Keep nothing in a reservation but whether it was given back
kazu-yamamoto Oct 17, 2026
908d692
Revert "Keep nothing in a reservation but whether it was given back"
kazu-yamamoto Oct 18, 2026
99c12a3
Update time-manager/System/ThreadManager.hs
kazu-yamamoto Oct 18, 2026
4589cf3
Update time-manager/System/ThreadManager.hs
kazu-yamamoto Oct 18, 2026
4048954
Update time-manager/System/ThreadManager.hs
kazu-yamamoto Oct 18, 2026
ad8c3c2
Update time-manager/System/ThreadManager.hs
kazu-yamamoto Oct 18, 2026
2e0cdaa
Say what the window after forkManaged is, without saying "scheduled"
kazu-yamamoto Oct 18, 2026
c0de72c
Say that withHandle is T.withHandle taking a ThreadManager
kazu-yamamoto Oct 18, 2026
e273c71
Test the cleanup of both Finally forks through one helper
kazu-yamamoto Oct 18, 2026
9100f94
Say getCount in terms of getCountSTM
kazu-yamamoto Oct 18, 2026
a9a7b11
Say why the thread under test does its own cleanup
kazu-yamamoto Oct 18, 2026
cf587c3
Say that an untaken place keeps waitUntilAllGone waiting
kazu-yamamoto Oct 18, 2026
e5b152d
Check that a stopped thread is still counted while it unwinds
kazu-yamamoto Oct 18, 2026
144e823
Name the exception the lock is there for
kazu-yamamoto Oct 18, 2026
1812be4
Name the fields of ThreadManager
kazu-yamamoto Oct 18, 2026
f9fc0ad
Fork through the caller's own fork, with the place kept for it
kazu-yamamoto Oct 18, 2026
453f5b6
warp: fork a connection through the thread manager
kazu-yamamoto Oct 18, 2026
48dcdcf
Update time-manager/System/ThreadManager.hs
kazu-yamamoto Oct 18, 2026
27fefb9
Update time-manager/System/ThreadManager.hs
kazu-yamamoto Oct 18, 2026
4d42617
Update time-manager/System/ThreadManager.hs
kazu-yamamoto Oct 18, 2026
179a3b5
Mention warp as an example, not as what this package serves
kazu-yamamoto Oct 18, 2026
e63034a
Give the fork's result back, and a version which takes a cleanup
kazu-yamamoto Oct 18, 2026
a1e9e79
Carry the recorded thread itself rather than its parts
kazu-yamamoto Oct 18, 2026
9ac745b
Keep nothing in a reservation but whether it was given back
kazu-yamamoto Oct 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions time-manager/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# ChangeLog for time-manager

## 0.4.1

* Count a thread in `System.ThreadManager` from when it is forked rather
than from when it starts, with `forkManagedBy`, `reserveManaged`,
`takeReservation` and `countManaged`.
[#1128](https://github.com/yesodweb/wai/pull/1128)
* Keep counting the threads `stopAfter` stopped until they end.
[#1128](https://github.com/yesodweb/wai/pull/1128)

## 0.4.0

* CHANGES IN BEHAVIOUR:
Expand Down
Loading
Loading