Skip to content

Write the keccak state in one literal #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jotabulacios wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Write the keccak state in one literal #1000

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b311e7
Write the keccak state in one literal
jotabulacios Sep 21, 2026
62c13a3
Make the literal's lane assumptions explicit
jotabulacios Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 39 additions & 13 deletions syscalls/src/keccak.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,19 +182,45 @@ pub fn keccak256(input: &[u8]) -> [u8; 32] {
/// over owned arrays — never an aligned doubleword load, which the VM would trap
/// on at a misaligned address.
pub fn keccak256_pair(left: &[u8; 32], right: &[u8; 32]) -> [u8; 32] {
let mut state = [0u64; 25];
// Bytes 0..64 span rate lanes 0..8: lanes 0..4 from `left`, 4..8 from `right`.
for i in 0..4 {
let l: &[u8; 8] = left[i * 8..i * 8 + 8].try_into().unwrap();
state[i] = u64::from_le_bytes(*l);
let r: &[u8; 8] = right[i * 8..i * 8 + 8].try_into().unwrap();
state[4 + i] = u64::from_le_bytes(*r);
}
// pad10*1 for a 64-byte message at rate 136: delimiter at byte 64 (lane 8,
// low byte) and the final bit at the last rate byte (byte 135, lane 16 high
// byte). Both target lanes are still zero, so XOR == assignment.
state[8] ^= u64::from(DELIMITER);
state[RATE_LANES - 1] ^= FINAL_PAD_LANE_BIT;
let lane = |b: &[u8; 32], i: usize| -> u64 {
let w: &[u8; 8] = b[i * 8..i * 8 + 8].try_into().unwrap();
u64::from_le_bytes(*w)
};
// Every lane written once, in one literal: zeroing all 25 and then
// overwriting 10 of them costs a memset per call, and this is the guest's
// hottest call. Bytes 0..64 span rate lanes 0..8 (0..4 from `left`, 4..8
// from `right`); pad10*1 for a 64-byte message at rate 136 puts the
// delimiter at byte 64 (lane 8, low byte) and the final bit at the last
// rate byte (byte 135, lane 16 high byte). Those lanes start zero, so the
// XORs the sponge would do are plain assignments.
let mut state: [u64; 25] = [
lane(left, 0),
lane(left, 1),
lane(left, 2),
lane(left, 3),
lane(right, 0),
lane(right, 1),
lane(right, 2),
lane(right, 3),
u64::from(DELIMITER),
0,
0,
0,
0,
0,
0,
0,
FINAL_PAD_LANE_BIT,
0,
0,
0,
0,
0,
0,
0,
0,
];
const _: () = assert!(RATE_LANES - 1 == 16);
Comment thread
jotabulacios marked this conversation as resolved.
Outdated
keccak_permute(&mut state);

let mut out = [0u8; 32];
Expand Down
Loading