Repository navigation
Conversation
index.HTML and photo.JPG missed the built-in MIME table, which is keyed by lowercase tags, and were served as application/octet-stream. Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
|
Thanks for the PR. Matching extensions case-insensitively would change the Content-Type served for existing files, which affects current users. I'd prefer to keep the current behavior unless there is a concrete need. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file_extensionkeeps the original case, andfind_content_typeswitched on lowercasestr2tagliterals.index.HTMLanda.JPGtherefore fell through toapplication/octet-stream.set_file_extension_and_mimetype_mappingstores the key in lowercase too, so a mapping registered asHTMLmatches.htmland.HTML.Test plan
find_content_type("dir/index.HTML")istext/html, anda.JPGisimage/jpegabcdematchesf.ABCDEFindContentTypeTest.ExtensionCaseIsIgnoredServerTest.UserDefinedMIMETypeMappingstill passes