Repository navigation
honour Keychain trust settings when loading macOS system CAs - #2641
Open
metsw24-max wants to merge 1 commit into
Open
metsw24-max wants to merge 1 commit into
metsw24-max wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Distrusted Keychain roots loaded as trusted CAs on macOS
The system CA loader takes every certificate that has Trust Settings in the system, admin or user domain as a trusted root without reading those settings, so a root set to "Never Trust" in Keychain Access, or trusted only for S/MIME or code signing, still verifies TLS servers. The loader now evaluates the settings for the SSL policy, with the user domain overriding admin and system, and the OpenSSL path shares the helper Mbed TLS and wolfSSL use.
Reviewer note: the decision follows SecTrustSettings.h (empty array means TrustRoot, first applicable usage constraint decides) and matches what Go's crypto/x509 did for the same issue; the unit test covers the shapes Keychain Access writes, since trust settings cannot be changed from a test without a GUI authorisation prompt.