Skip to content

Switch to yt.hub for hosting data files#108

Open
Xarthisius wants to merge 1 commit into
yt-project:mainfrom
Xarthisius:hub_data
Open

Switch to yt.hub for hosting data files#108
Xarthisius wants to merge 1 commit into
yt-project:mainfrom
Xarthisius:hub_data

Conversation

@Xarthisius

Copy link
Copy Markdown
Member

No more hand-editing of json files...

@Xarthisius

Copy link
Copy Markdown
Member Author

@yt-fido test this please.

@neutrinoceros

Copy link
Copy Markdown
Member

This completely breaks yt.load_sample, see https://github.com/yt-project/yt/blob/89424c2196ff29629f2066a188e44e946099fca2/yt/sample_data/api.py#L88

I am nonetheless fine with it, because I don't like that yt.load_sample relies on this file instead of the website itself, but I would really like that we think of a solution before we ship this.

@Xarthisius

Xarthisius commented Jun 17, 2021

Copy link
Copy Markdown
Member Author

This completely breaks yt.load_sample, see https://github.com/yt-project/yt/blob/89424c2196ff29629f2066a188e44e946099fca2/yt/sample_data/api.py#L88

I am nonetheless fine with it, because I don't like that yt.load_sample relies on this file instead of the website itself, but I would really like that we think of a solution before we ship this.

There's going to be an endpoint that generates json required by load_sample on the fly too. We're doing this cause server that hosts yt-project.org is going away...

@neutrinoceros

Copy link
Copy Markdown
Member

yeah it looks okay, and I think this is actually an improvement for yt.load_sample too. I wrote my first comment very quickly to avoid a pre-mature merge. Now I think it should be pretty easy to patch the yt side first and then all is well !

@Xarthisius

Copy link
Copy Markdown
Member Author

yeah it looks okay, and I think this is actually an improvement for yt.load_sample too. I wrote my first comment very quickly to avoid a pre-mature merge. Now I think it should be pretty easy to patch the yt side first and then all is well !

The removal of datafiles.json is easy to fix, cause you can replace url in yt to the same url as in this PR, but the download urls change and that breaks load_sample.

@jzuhone

jzuhone commented Feb 22, 2022

Copy link
Copy Markdown
Contributor

@Xarthisius @neutrinoceros what's the status of this?

@neutrinoceros

Copy link
Copy Markdown
Member

@jzuhone I believe this PR was a companion to yt-project/yt#3366

@matthewturk

Copy link
Copy Markdown
Member

Should we still try to push this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants