Long running tests process because of search inside all node_modules installed#97
Closed
paulRbr wants to merge 1 commit into
Closed
Long running tests process because of search inside all node_modules installed#97paulRbr wants to merge 1 commit into
paulRbr wants to merge 1 commit into
Conversation
Author
|
Ignore this PR, as we can need dependencies from node_modules... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I get a long running process searching for all modules that have a
build.jsonfile.This PR checks the path of the modules parsed to not include the node_modules ones.
As in my other pr #96, all tests pass correctly
npm test -f(in order to pass the linting errors) makes the tests pass: