refactor!: chart naming and expose other useful library functions - #5107
Open
Racer159 wants to merge 14 commits into
Open
refactor!: chart naming and expose other useful library functions#5107Racer159 wants to merge 14 commits into
Racer159 wants to merge 14 commits into
Conversation
✅ Deploy Preview for zarf-docs canceled.
|
Signed-off-by: Wayne Starr <me@racer159.com>
Racer159
force-pushed
the
chore/expose-more-library-functions
branch
from
July 24, 2026 01:14
29af83c to
9000b66
Compare
Signed-off-by: Wayne Starr <me@racer159.com>
…ePortURL Signed-off-by: Wayne Starr <me@racer159.com>
Racer159
force-pushed
the
chore/expose-more-library-functions
branch
from
July 25, 2026 01:36
3ec9679 to
7dc7965
Compare
Signed-off-by: Wayne Starr <me@racer159.com>
Signed-off-by: Wayne Starr <me@racer159.com>
Racer159
marked this pull request as ready for review
July 27, 2026 17:16
AustinAbro321
requested changes
Jul 27, 2026
AustinAbro321
left a comment
AustinAbro321
left a comment
Member
There was a problem hiding this comment.
Overall design mostly looks good, as well as a few QOL fixes. Requesting changes on the Helm interface
Member
|
@Racer159 Could you rename this PR to begin with "refactor" instead of Chore. Also if there are any breaking changes to public exported function signatures, please call them out in the description and add a ! to refactor. |
Racer159
changed the title
Signed-off-by: Wayne Starr <me@racer159.com>
Racer159
changed the title
Signed-off-by: Wayne Starr <me@racer159.com>
Signed-off-by: Wayne Starr <me@racer159.com>
Racer159
force-pushed
the
chore/expose-more-library-functions
branch
from
July 27, 2026 22:12
e415266 to
3df4592
Compare
AustinAbro321
left a comment
AustinAbro321
left a comment
Member
There was a problem hiding this comment.
Some minor asks, design looks good
Signed-off-by: Wayne Starr <me@racer159.com>
AustinAbro321
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This exposes some additional functions to help library users normalize logic with Zarf. These changes include:
layoutpackage so that others can use it - this also disambiguates the layout/naming responsibilities betweenhelmandlayoutmakinglayoutthe package that defines it for Zarf packages.ResolvePlainHTTPlogic so that callers can match how Zarf determines this if they want to interact with the Zarf registry directly.CRCTagon its own so that callers can resolve the canonical tag name Zarf uses when pushing images to the registry (without needing to strip it from the full registry transform).ServiceInfoFromNodePortURLso that callers can follow the same logic Zarf uses to interpret what K8s service is tied to a nodeport URL.Caution
Breaking library changes:
cluster.Registry{Server,Client}TLSSecretandcluster.RegistrySecret{CA,Cert,Key}Pathmoved to
state. Values are byte-identical; only the package changed.layout.PackageChartsignature changed:(ctx, chart, packagePath, chartPath, valuesFilePath, cachePath string, remoteOpts)->(ctx, chart, packagePath string, paths ChartPaths, cachePath string, remoteOpts).Two path strings collapsed into one
ChartPaths- requires some changes but should alsobreak compilers to highlight the change.
layout.AssemblePackage(and associated functions) moved toassemble.AssemblePackageRelated Issue
Fixes #4047
Fixes #4518
Relates to #5096
Relates to #5097
Checklist before merging