You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
util.py: Remove the node-restart workaround from rebuild_cache(). Sync now relies solely on sync_blocks(), which is the correct behavior now that the Zebra fix has landed.
Rebased onto current main (was 12 commits behind; last full CI predated #138).
Conflict was in util.py's initialize_chain cache builder, where main had since added the zebra-broadcast workaround (sync_blocks_with_reconnect + stop/restart all zebrads, zebra #10329/#10332). Resolved in favor of this PR's intent — removing the workaround now that ZcashFoundation/zebra#10403 has merged — so cache sync relies solely on sync_blocks(rpcs) (60s timeout: fails fast rather than hanging if the broadcast fix isn't present). Also dropped the now-orphaned sync_blocks_with_reconnect helper, which only existed to serve that workaround.
The new regtest_block_relay.py is in NEW_SCRIPTS with cache_behavior='clean', so it does not trigger the 8-node cache pre-populate that #138 just fixed. This CI run is the real check that zebra#10403 is in the test binaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on ZcashFoundation/zebra#10403(merged)util.py: Remove the node-restart workaround from rebuild_cache(). Sync now relies solely onsync_blocks(), which is the correct behavior now that the Zebra fix has landed.regtest_block_relay.py: New regression test for bug(network): Zebra broadcasting in regtest mode ZcashFoundation/zebra#10332 (comment). Three nodes in a linearA -- B -- Ctopology; node A mines 10 blocks; asserts all nodes reach height 10. This is the minimal reproduction case from the issue.